Skip to content

Commit 0939f39

Browse files
authored
[SYCL] Align assert ext name with libdevice implementation (#13312)
In native assert design (https://github.com/intel/llvm/blob/sycl/sycl/doc/extensions/supported/sycl_ext_oneapi_assert.asciidoc), fallback implementation is used only when native support is not available for underlying device(OCL CPU/GPU, level 0 GPU). The fallback implementation for assert is provided via sycl device libraries and fallback mechanism requires that any underlying device which provides native assert should also expose 'cl_intel_devicelib_assert' extension for sycl runtime to check. Latest OCL cpu runtime has already provided native assert and expose this ext string, but we find the fallback implementation is still used instead of native version on OCL CPU device. The reason is sycl runtime used a different string for checking: "pi_ext_intel_devicelib_assert", so this PR fixes it. --------- Signed-off-by: jinge90 <[email protected]>
1 parent fb66f1b commit 0939f39

File tree

1 file changed

+1
-2
lines changed
  • sycl/include/sycl/detail

1 file changed

+1
-2
lines changed

sycl/include/sycl/detail/pi.h

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -957,8 +957,7 @@ static const uint8_t PI_DEVICE_BINARY_OFFLOAD_KIND_SYCL = 4;
957957
/// Extension to denote native support of assert feature by an arbitrary device
958958
/// piDeviceGetInfo call should return this extension when the device supports
959959
/// native asserts if supported extensions' names are requested
960-
#define PI_DEVICE_INFO_EXTENSION_DEVICELIB_ASSERT \
961-
"pi_ext_intel_devicelib_assert"
960+
#define PI_DEVICE_INFO_EXTENSION_DEVICELIB_ASSERT "cl_intel_devicelib_assert"
962961

963962
/// Device binary image property set names recognized by the SYCL runtime.
964963
/// Name must be consistent with

0 commit comments

Comments
 (0)