[SYCL] Align assert ext name with libdevice implementation #13312
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jinge90 <[email protected]>
Signed-off-by: jinge90 <[email protected]>
dm-vodopyanov
approved these changes
Apr 8, 2024
|
Hi, @intel/llvm-gatekeepers |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In native assert design (https://github.com/intel/llvm/blob/sycl/sycl/doc/extensions/supported/sycl_ext_oneapi_assert.asciidoc), fallback implementation is used only when native support is not available for underlying device(OCL CPU/GPU, level 0 GPU). The fallback implementation for assert is provided via sycl device libraries and fallback mechanism requires that any underlying device which provides native assert should also expose 'cl_intel_devicelib_assert' extension for sycl runtime to check. Latest OCL cpu runtime has already provided native assert and expose this ext string, but we find the fallback implementation is still used instead of native version on OCL CPU device.
The reason is sycl runtime used a different string for checking: "pi_ext_intel_devicelib_assert", so this PR fixes it.