Skip to content

Commit 120667d

Browse files
[SYCL][E2E] minor test change to ease release (#17325)
The debug story for sycl-jit is not determined yet, so supporting the `-g` flag for the kernel_compiler is not a strict requirement. Meanwhile, on the SPIR-V side we are changing some opcodes to be extensions. This upshot of all that is that between the open source and closed source side, drivers and code gen, the -g flag, *when passed to the kernel_compiler*, is leading to errors. This will resolve itself once both the open source and closed source sides of the compiler, and the matching drivers, have all made the switch to the same SPIRV symbols. In the meantime, these tests are being adjusted so they pass in all contexts.
1 parent 65498a6 commit 120667d

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

sycl/test-e2e/KernelCompiler/kernel_compiler_sycl.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -161,7 +161,7 @@ void test_build_and_run() {
161161

162162
// Compilation with props and devices
163163
std::string log;
164-
std::vector<std::string> flags{"-g", "-fno-fast-math"};
164+
std::vector<std::string> flags{"-fno-fast-math"};
165165
std::vector<sycl::device> devs = kbSrc.get_devices();
166166
exe_kb kbExe2 = syclex::build(
167167
kbSrc, devs,

sycl/test-e2e/KernelCompiler/kernel_compiler_sycl_jit.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -259,7 +259,7 @@ int test_build_and_run() {
259259

260260
// Compilation with props and devices
261261
std::string log;
262-
std::vector<std::string> flags{"-g", "-fno-fast-math",
262+
std::vector<std::string> flags{"-fno-fast-math",
263263
"-fsycl-instrument-device-code"};
264264
std::vector<sycl::device> devs = kbSrc.get_devices();
265265
exe_kb kbExe2 = syclex::build(

sycl/test-e2e/KernelCompiler/kernel_compiler_sycl_jit_cache.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,7 @@ int test_persistent_cache() {
9696
// Different build_options means no cache hit.
9797
// CHECK: [kernel_compiler Persistent Cache]: cache miss: [[KEY2:.*]]
9898
// CHECK: [kernel_compiler Persistent Cache]: storing device code IR: {{.*}}/[[KEY2]]
99-
std::vector<std::string> flags{"-g", "-fno-fast-math"};
99+
std::vector<std::string> flags{"-O0", "-fno-fast-math"};
100100
exe_kb kbExe1c =
101101
syclex::build(kbSrc1, syclex::properties{syclex::build_options{flags}});
102102

0 commit comments

Comments
 (0)