Skip to content

[SYCL][E2E] minor test change to ease release #17325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 6, 2025

Conversation

cperkinsintel
Copy link
Contributor

The debug story for sycl-jit is not determined yet, so supporting the -g flag for the kernel_compiler is not a strict requirement.
Meanwhile, on the SPIR-V side we are changing some opcodes to be extensions. This upshot of all that is that between the open source and closed source side, drivers and code gen, the -g flag, when passed to the kernel_compiler, is leading to errors. This will resolve itself once both the open source and closed source sides of the compiler, and the matching drivers, have all made the switch to the same SPIRV symbols. In the meantime, these tests are being adjusted so they pass in all contexts.

@cperkinsintel cperkinsintel changed the title [SYCL] minor test change to ease release [SYCL][E2E] minor test change to ease release Mar 6, 2025
@cperkinsintel cperkinsintel marked this pull request as ready for review March 6, 2025 18:13
@cperkinsintel cperkinsintel requested a review from a team as a code owner March 6, 2025 18:13
@cperkinsintel
Copy link
Contributor Author

cperkinsintel commented Mar 6, 2025

This is a test only change, the failures in other tests are unrelated.

Issue: #17339

@againull
Copy link
Contributor

againull commented Mar 6, 2025

Unrelated failures:

Timed Out Tests (1):
SYCL :: WorkGroupMemory/basic_usage.cpp

Failed Tests (4):
SYCL :: Basic/built-ins/vec_math.cpp
SYCL :: Basic/built-ins/vec_relational.cpp
SYCL :: Reduction/reduction_big_data.cpp
SYCL :: Reduction/reduction_nd_ext_half.cpp

on AMD reported in #17339

@againull againull merged commit 120667d into intel:sycl Mar 6, 2025
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants