Skip to content

Commit 1b44be3

Browse files
[CI] Remove sycl-devops-pr/** hack
It was originally added in #10002, back when we used `pull_request_target` for pre-commit trigger. Now that `pull_request` is used it isn't (as) necessary. I'm also adding a `workflow_dispatch` trigger for the post-commit job for cases when somebody wants to test extensive non-CI changes with post-commit before the merge. I think that will work but it's impossible to verify before merging this due to how GHA work. This will address the following usage scenario: * Push CI-related changes to `sycl-devops-pr` (possibly several iterations) * Result are ok, open a PR from that branch - extra post-commit task is spawned for the commit that has been tested already (this duplication will remain, unfortunately) * Address review feedback with a new upload - two post-commit jobs are automatically launched (after this PR, no manual dispatch would happen here, leaving only automatic pre-commit testing of the post-commit workflow)
1 parent 0d09eb1 commit 1b44be3

File tree

4 files changed

+2
-5
lines changed

4 files changed

+2
-5
lines changed

.github/workflows/pr-code-format.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@ on:
88
branches:
99
- main
1010
- sycl
11-
- sycl-devops-pr/**
1211
- sycl-rel-**
1312
- 'users/**'
1413

.github/workflows/sycl-linux-precommit.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@ on:
77
pull_request:
88
branches:
99
- sycl
10-
- sycl-devops-pr/**
1110
- sycl-rel-**
1211
# Do not run builds if changes are only in the following locations
1312
paths-ignore:

.github/workflows/sycl-post-commit.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,16 @@
11
name: SYCL Post Commit
22

33
on:
4+
workflow_dispatch:
5+
46
push:
57
branches:
68
- sycl
7-
- sycl-devops-pr/**
89
- sycl-rel-**
910

1011
pull_request:
1112
branches:
1213
- sycl
13-
- sycl-devops-pr/**
1414
paths:
1515
- .github/workflows/sycl-post-commit.yml
1616
- .github/workflows/sycl-linux-build.yml

.github/workflows/sycl-windows-precommit.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ on:
44
pull_request:
55
branches:
66
- sycl
7-
- sycl-devops-pr/**
87
- llvmspirv_pulldown
98
- sycl-rel-**
109
# Do not run builds if changes are only in the following locations

0 commit comments

Comments
 (0)