[CI] Let sycl-devops-pr/** branches trigger pre/post-commit #10002
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In #9950 I envisioned a setup when there will be a dedicated devops pre-commit task that would create fake branch/PR in the repository to verify changes affecting CI. I later realized that we can just push the source branch for such a PR directly to origin and use that for testing. As such, rename which branch is allowed to trigger post-commit and allow the same for pre-commit.
|
Tested I've cancelled both of the runs after initial/first task finished because the trigger itself is being changed in this PR. |
aelovikov-intel
added a commit
that referenced
this pull request
Jan 23, 2025
It was originally added in #10002, back when we used `pull_request_target` for pre-commit trigger. Now that `pull_request` is used it isn't (as) necessary. I'm also adding a `workflow_dispatch` trigger for the post-commit job for cases when somebody wants to test extensive non-CI changes with post-commit before the merge. I think that will work but it's impossible to verify before merging this due to how GHA work. This will address the following usage scenario: * Push CI-related changes to `sycl-devops-pr` (possibly several iterations) * Result are ok, open a PR from that branch - extra post-commit task is spawned for the commit that has been tested already (this duplication will remain, unfortunately) * Address review feedback with a new upload - two post-commit jobs are automatically launched (after this PR, no manual dispatch would happen here, leaving only automatic pre-commit testing of the post-commit workflow)
aelovikov-intel
added a commit
that referenced
this pull request
Jan 23, 2025
It was originally added in #10002, back when we used `pull_request_target` for pre-commit trigger. Now that `pull_request` is used it isn't (as) necessary. I'm also adding a `workflow_dispatch` trigger for the post-commit job for cases when somebody wants to test extensive non-CI changes with post-commit before the merge. I think that will work but it's impossible to verify before merging this due to how GHA work. This will address the following usage scenario: * Push CI-related changes to `sycl-devops-pr` (possibly several iterations) * Result are ok, open a PR from that branch - extra post-commit task is spawned for the commit that has been tested already (this duplication will remain, unfortunately) * Address review feedback with a new upload - two post-commit jobs are automatically launched (after this PR, no manual dispatch would happen here, leaving only automatic pre-commit testing of the post-commit workflow)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #9950 I envisioned a setup when there will be a dedicated devops pre-commit task that would create fake branch/PR in the repository to verify changes affecting CI. I later realized that we can just push the source branch for such a PR directly to origin and use that for testing.
As such, rename which branch is allowed to trigger post-commit and allow the same for pre-commit. Future changes are expected to be done like this:
sycl-devops-pr/<name>in intel/llvm repo, it willrun post-commit testing.
sycl-devops-pr/<name>, that will run pre-commit testing.