[CI] Change trigger events for post commit task #9950
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1) Don't run in pre-commit to enhance security 2) Run automatically when on a push to a branch starting with "test-devops/pr" to enable testing for CI-related changes
aelovikov-intel
added a commit
that referenced
this pull request
Jun 20, 2023
In #9950 I envisioned a setup when there will be a dedicated devops pre-commit task that would create fake branch/PR in the repository to verify changes affecting CI. I later realized that we can just push the source branch for such a PR directly to origin and use that for testing. As such, rename which branch is allowed to trigger post-commit and allow the same for pre-commit.
aelovikov-intel
added a commit
that referenced
this pull request
Jun 21, 2023
In #9950 I envisioned a setup when there will be a dedicated devops pre-commit task that would create fake branch/PR in the repository to verify changes affecting CI. I later realized that we can just push the source branch for such a PR directly to origin and use that for testing. As such, rename which branch is allowed to trigger post-commit and allow the same for pre-commit. Future changes are expected to be done like this: - create branch `sycl-devops-pr/<name>` in *intel*/llvm repo, it will run post-commit testing. - create PR out of that branch - create an extra draft PR with a target branch set to the same `sycl-devops-pr/<name>`, that will run pre-commit testing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"test-devops-pr" to enable testing for CI-related changes