[SYCL] Fix kernel argument cast kind (#914)

We insert a cast in SemaSYCL only if address spaces of pointee types
are different. However, ImplicitCastExpr checks for pointee types only
if the cast is RValue.

Signed-off-by: Andrew Savonichev <[email protected]>

Author: Andrew Savonichev

clang/lib/Sema/SemaSYCL.cpp

@@ -889,7 +889,7 @@ static CompoundStmt *CreateOpenCLKernelBody(Sema &S,
                 ParamType->getPointeeType().getAddressSpace())
           DRE = ImplicitCastExpr::Create(S.Context, FieldType,
                                          CK_AddressSpaceConversion, DRE,
-                                         nullptr, VK_LValue);
+                                         nullptr, VK_RValue);
         InitializationKind InitKind =
             InitializationKind::CreateCopy(SourceLocation(), SourceLocation());
         InitializationSequence InitSeq(S, Entity, InitKind, DRE);

clang/test/SemaSYCL/built-in-type-kernel-arg.cpp

@@ -83,11 +83,9 @@ int main() {
 
 // Check that lambda fields of pointer types are initialized
 // CHECK: InitListExpr
-// CHECK-NEXT: ImplicitCastExpr {{.*}} 'int *' <LValueToRValue>
-// CHECK-NEXT: ImplicitCastExpr {{.*}} 'int *' lvalue <AddressSpaceConversion>
+// CHECK-NEXT: ImplicitCastExpr {{.*}} 'int *' <AddressSpaceConversion>
 // CHECK-NEXT: DeclRefExpr {{.*}} '__global int *' lvalue ParmVar {{.*}} '_arg_' '__global int *'
-// CHECK-NEXT: ImplicitCastExpr {{.*}} 'int *' <LValueToRValue>
-// CHECK-NEXT: ImplicitCastExpr {{.*}} 'int *' lvalue <AddressSpaceConversion>
+// CHECK-NEXT: ImplicitCastExpr {{.*}} 'int *' <AddressSpaceConversion>
 // CHECK-NEXT: DeclRefExpr {{.*}} '__global int *' lvalue ParmVar {{.*}} '_arg_' '__global int *'
 
 // Check kernel parameters