[SYCL] Fix kernel argument cast kind #914
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We insert a cast in SemaSYCL only if address spaces of pointee types are different. However, ImplicitCastExpr checks for pointee types only if the cast is RValue. Signed-off-by: Andrew Savonichev <[email protected]>
Fznamznon
approved these changes
Dec 6, 2019
erichkeane
approved these changes
Dec 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We insert a cast in SemaSYCL only if address spaces of pointee types
are different. However, ImplicitCastExpr checks for pointee types only
if the cast is RValue.
This patch fixes a regression when this check is enabled: a29aa47#diff-dac09655ff6a54658c320a28a6ea297cR1817
Signed-off-by: Andrew Savonichev [email protected]