Skip to content

Commit 248da2e

Browse files
[SYCL] Return some Windows symbols in library back (#4244)
This patch returns some of the symbols of the library which had @oneapi@sycl@ before #4014 , and after that they were renamed to @oneapi@ext@sycl@. These symbols can't be used by users because the fully internal class stream_impl was exported, so nothing breaks. Anyway, some symbols were removed in comparison with Gold, and we can't change ABI yet. During the timeframe where we can break ABI, we can fix stream_impl by removing `__SYCL_EXPORT` from it.
1 parent a292214 commit 248da2e

File tree

2 files changed

+10
-0
lines changed

2 files changed

+10
-0
lines changed

sycl/source/CMakeLists.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -171,6 +171,7 @@ set(SYCL_SOURCES
171171
"spirv_ops.cpp"
172172
"$<$<PLATFORM_ID:Windows>:detail/windows_pi.cpp>"
173173
"$<$<OR:$<PLATFORM_ID:Linux>,$<PLATFORM_ID:Darwin>>:detail/posix_pi.cpp>"
174+
"$<$<PLATFORM_ID:Windows>:abi_replacements_windows.cpp>"
174175
)
175176

176177
if (MSVC)
Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
#pragma comment( \
2+
linker, \
3+
"/export:?accessGlobalBuf@stream_impl@detail@sycl@cl@@QEAA?AV?$accessor@D$00$0EAC@$0HNO@$0A@V?$accessor_property_list@$$V@ONEAPI@sycl@cl@@@34@AEAVhandler@34@@Z=?accessGlobalBuf@stream_impl@detail@sycl@cl@@QEAA?AV?$accessor@D$00$0EAC@$0HNO@$0A@V?$accessor_property_list@$$V@oneapi@ext@sycl@cl@@@34@AEAVhandler@34@@Z")
4+
#pragma comment( \
5+
linker, \
6+
"/export:?accessGlobalFlushBuf@stream_impl@detail@sycl@cl@@QEAA?AV?$accessor@D$00$0EAC@$0HNO@$0A@V?$accessor_property_list@$$V@ONEAPI@sycl@cl@@@34@AEAVhandler@34@@Z=?accessGlobalFlushBuf@stream_impl@detail@sycl@cl@@QEAA?AV?$accessor@D$00$0EAC@$0HNO@$0A@V?$accessor_property_list@$$V@oneapi@ext@sycl@cl@@@34@AEAVhandler@34@@Z")
7+
#pragma comment( \
8+
linker, \
9+
"/export:?accessGlobalOffset@stream_impl@detail@sycl@cl@@QEAA?AV?$accessor@I$00$0EAF@$0HNO@$0A@V?$accessor_property_list@$$V@ONEAPI@sycl@cl@@@34@AEAVhandler@34@@Z=?accessGlobalOffset@stream_impl@detail@sycl@cl@@QEAA?AV?$accessor@I$00$0EAF@$0HNO@$0A@V?$accessor_property_list@$$V@oneapi@ext@sycl@cl@@@34@AEAVhandler@34@@Z")

0 commit comments

Comments
 (0)