-
Notifications
You must be signed in to change notification settings - Fork 787
[SYCL] Return some Windows symbols in library back #4244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SYCL] Return some Windows symbols in library back #4244
Conversation
This patch returns some unnecessary exported symbols on Windows which could not be used by customers, and their absence didn't break anything in user's application.
/summary:run |
/summary:run |
Jenkins/Summary failures cannot be related to this patch as test suite in it failed on Linux only. This patch has only Windows changes. |
I would prefer if @romanovvlad gives another look and merge it. @dm-vodopyanov, please, file a ticket on unrelated failure. |
This sounds like you are adding some garbage to the library. Could you clarify why you are doing that? |
Created an internal ticket. The failure looks like an infra issue.
That's absolutely true. These garbage symbols were removed from the library because Windows has very broad names of exported symbols and some of the symbols of the library had |
This patch returns some of the symbols of the library which
had @oneapi@sycl@ before #4014 , and after that they were
renamed to @oneapi@ext@sycl@. These symbols can't be used
by users because the fully internal class stream_impl was exported,
so nothing breaks. Anyway, some symbols were removed in
comparison with Gold, and we can't change ABI yet. During the
timeframe where we can break ABI, we can fix stream_impl by
removing
__SYCL_EXPORT
from it.