Skip to content

Commit 254ade7

Browse files
Bensuomfrancepillois
Bensuo
authored and
mfrancepillois
committed
[SYCL][Graph] Add missing fill stubs and abi symbol checks (#315)
1 parent d314fde commit 254ade7

10 files changed

+128
-7
lines changed

‎sycl/plugins/cuda/pi_cuda.cpp

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1137,6 +1137,27 @@ pi_result piextCommandBufferMemBufferWriteRect(
11371137
NumSyncPointsInWaitList, SyncPointWaitList, SyncPoint);
11381138
}
11391139

1140+
pi_result piextCommandBufferMemBufferFill(
1141+
pi_ext_command_buffer CommandBuffer, pi_mem Buffer, const void *Pattern,
1142+
size_t PatternSize, size_t Offset, size_t Size,
1143+
pi_uint32 NumSyncPointsInWaitList,
1144+
const pi_ext_sync_point *SyncPointWaitList, pi_ext_sync_point *SyncPoint) {
1145+
return pi2ur::piextCommandBufferMemBufferFill(
1146+
CommandBuffer, Buffer, Pattern, PatternSize, Offset, Size,
1147+
NumSyncPointsInWaitList, SyncPointWaitList, SyncPoint);
1148+
}
1149+
1150+
pi_result piextCommandBufferFillUSM(pi_ext_command_buffer CommandBuffer,
1151+
void *Ptr, const void *Pattern,
1152+
size_t PatternSize, size_t Size,
1153+
pi_uint32 NumSyncPointsInWaitList,
1154+
const pi_ext_sync_point *SyncPointWaitList,
1155+
pi_ext_sync_point *SyncPoint) {
1156+
return pi2ur::piextCommandBufferFillUSM(
1157+
CommandBuffer, Ptr, Pattern, PatternSize, Size, NumSyncPointsInWaitList,
1158+
SyncPointWaitList, SyncPoint);
1159+
}
1160+
11401161
pi_result piextEnqueueCommandBuffer(pi_ext_command_buffer CommandBuffer,
11411162
pi_queue Queue,
11421163
pi_uint32 NumEventsInWaitList,

‎sycl/plugins/hip/pi_hip.cpp

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1145,6 +1145,27 @@ pi_result piextCommandBufferMemBufferWriteRect(
11451145
NumSyncPointsInWaitList, SyncPointWaitList, SyncPoint);
11461146
}
11471147

1148+
pi_result piextCommandBufferMemBufferFill(
1149+
pi_ext_command_buffer CommandBuffer, pi_mem Buffer, const void *Pattern,
1150+
size_t PatternSize, size_t Offset, size_t Size,
1151+
pi_uint32 NumSyncPointsInWaitList,
1152+
const pi_ext_sync_point *SyncPointWaitList, pi_ext_sync_point *SyncPoint) {
1153+
return pi2ur::piextCommandBufferMemBufferFill(
1154+
CommandBuffer, Buffer, Pattern, PatternSize, Offset, Size,
1155+
NumSyncPointsInWaitList, SyncPointWaitList, SyncPoint);
1156+
}
1157+
1158+
pi_result piextCommandBufferFillUSM(pi_ext_command_buffer CommandBuffer,
1159+
void *Ptr, const void *Pattern,
1160+
size_t PatternSize, size_t Size,
1161+
pi_uint32 NumSyncPointsInWaitList,
1162+
const pi_ext_sync_point *SyncPointWaitList,
1163+
pi_ext_sync_point *SyncPoint) {
1164+
return pi2ur::piextCommandBufferFillUSM(
1165+
CommandBuffer, Ptr, Pattern, PatternSize, Size, NumSyncPointsInWaitList,
1166+
SyncPointWaitList, SyncPoint);
1167+
}
1168+
11481169
pi_result piextEnqueueCommandBuffer(pi_ext_command_buffer CommandBuffer,
11491170
pi_queue Queue,
11501171
pi_uint32 NumEventsInWaitList,

‎sycl/plugins/opencl/pi_opencl.cpp

Lines changed: 53 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1081,13 +1081,59 @@ pi_result piextCommandBufferMemBufferWriteRect(
10811081
NumSyncPointsInWaitList, SyncPointWaitList, SyncPoint);
10821082
}
10831083

1084-
pi_result piextEnqueueCommandBuffer(pi_ext_command_buffer CommandBuffer,
1085-
pi_queue Queue,
1086-
pi_uint32 NumEventsInWaitList,
1087-
const pi_event *EventWaitList,
1088-
pi_event *Event) {
1089-
return pi2ur::piextEnqueueCommandBuffer(
1090-
CommandBuffer, Queue, NumEventsInWaitList, EventWaitList, Event);
1084+
pi_result
1085+
piextCommandBufferMemBufferFill(pi_ext_command_buffer command_buffer,
1086+
pi_mem buffer, const void *pattern,
1087+
size_t pattern_size, size_t offset, size_t size,
1088+
pi_uint32 num_sync_points_in_wait_list,
1089+
const pi_ext_sync_point *sync_point_wait_list,
1090+
pi_ext_sync_point *sync_point) {
1091+
(void)command_buffer;
1092+
(void)buffer;
1093+
(void)pattern;
1094+
(void)pattern_size;
1095+
(void)offset;
1096+
(void)size;
1097+
(void)num_sync_points_in_wait_list;
1098+
(void)sync_point_wait_list;
1099+
(void)sync_point;
1100+
1101+
// Not implemented
1102+
return PI_ERROR_INVALID_OPERATION;
1103+
}
1104+
1105+
pi_result
1106+
piextCommandBufferFillUSM(pi_ext_command_buffer command_buffer, void *ptr,
1107+
const void *pattern, size_t pattern_size, size_t size,
1108+
pi_uint32 num_sync_points_in_wait_list,
1109+
const pi_ext_sync_point *sync_point_wait_list,
1110+
pi_ext_sync_point *sync_point) {
1111+
(void)command_buffer;
1112+
(void)ptr;
1113+
(void)pattern;
1114+
(void)pattern_size;
1115+
(void)size;
1116+
(void)num_sync_points_in_wait_list;
1117+
(void)sync_point_wait_list;
1118+
(void)sync_point;
1119+
1120+
// Not implemented
1121+
return PI_ERROR_INVALID_OPERATION;
1122+
}
1123+
1124+
pi_result piextEnqueueCommandBuffer(pi_ext_command_buffer command_buffer,
1125+
pi_queue queue,
1126+
pi_uint32 num_events_in_wait_list,
1127+
const pi_event *event_wait_list,
1128+
pi_event *event) {
1129+
(void)command_buffer;
1130+
(void)queue;
1131+
(void)num_events_in_wait_list;
1132+
(void)event_wait_list;
1133+
(void)event;
1134+
1135+
// Not implemented
1136+
return PI_ERROR_INVALID_OPERATION;
10911137
}
10921138

10931139
pi_result piextPluginGetOpaqueData(void *opaque_data_param,

‎sycl/plugins/unified_runtime/pi_unified_runtime.cpp

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1102,6 +1102,27 @@ pi_result piextCommandBufferMemBufferWriteRect(
11021102
NumSyncPointsInWaitList, SyncPointWaitList, SyncPoint);
11031103
}
11041104

1105+
pi_result piextCommandBufferMemBufferFill(
1106+
pi_ext_command_buffer CommandBuffer, pi_mem Buffer, const void *Pattern,
1107+
size_t PatternSize, size_t Offset, size_t Size,
1108+
pi_uint32 NumSyncPointsInWaitList,
1109+
const pi_ext_sync_point *SyncPointWaitList, pi_ext_sync_point *SyncPoint) {
1110+
return pi2ur::piextCommandBufferMemBufferFill(
1111+
CommandBuffer, Buffer, Pattern, PatternSize, Offset, Size,
1112+
NumSyncPointsInWaitList, SyncPointWaitList, SyncPoint);
1113+
}
1114+
1115+
pi_result piextCommandBufferFillUSM(pi_ext_command_buffer CommandBuffer,
1116+
void *Ptr, const void *Pattern,
1117+
size_t PatternSize, size_t Size,
1118+
pi_uint32 NumSyncPointsInWaitList,
1119+
const pi_ext_sync_point *SyncPointWaitList,
1120+
pi_ext_sync_point *SyncPoint) {
1121+
return pi2ur::piextCommandBufferFillUSM(
1122+
CommandBuffer, Ptr, Pattern, PatternSize, Size, NumSyncPointsInWaitList,
1123+
SyncPointWaitList, SyncPoint);
1124+
}
1125+
11051126
pi_result piextEnqueueCommandBuffer(pi_ext_command_buffer CommandBuffer,
11061127
pi_queue Queue,
11071128
pi_uint32 NumEventsInWaitList,

‎sycl/test/abi/pi_cuda_symbol_check.dump

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -84,9 +84,11 @@ piSamplerRetain
8484
piTearDown
8585
piextBindlessImageSamplerCreate
8686
piextCommandBufferCreate
87+
piextCommandBufferFillUSM
8788
piextCommandBufferFinalize
8889
piextCommandBufferMemBufferCopy
8990
piextCommandBufferMemBufferCopyRect
91+
piextCommandBufferMemBufferFill
9092
piextCommandBufferMemBufferRead
9193
piextCommandBufferMemBufferReadRect
9294
piextCommandBufferMemBufferWrite

‎sycl/test/abi/pi_hip_symbol_check.dump

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -84,9 +84,11 @@ piSamplerRetain
8484
piTearDown
8585
piextBindlessImageSamplerCreate
8686
piextCommandBufferCreate
87+
piextCommandBufferFillUSM
8788
piextCommandBufferFinalize
8889
piextCommandBufferMemBufferCopy
8990
piextCommandBufferMemBufferCopyRect
91+
piextCommandBufferMemBufferFill
9092
piextCommandBufferMemBufferRead
9193
piextCommandBufferMemBufferReadRect
9294
piextCommandBufferMemBufferWrite

‎sycl/test/abi/pi_level_zero_symbol_check.dump

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -83,9 +83,11 @@ piSamplerRetain
8383
piTearDown
8484
piextBindlessImageSamplerCreate
8585
piextCommandBufferCreate
86+
piextCommandBufferFillUSM
8687
piextCommandBufferFinalize
8788
piextCommandBufferMemBufferCopy
8889
piextCommandBufferMemBufferCopyRect
90+
piextCommandBufferMemBufferFill
8991
piextCommandBufferMemBufferRead
9092
piextCommandBufferMemBufferReadRect
9193
piextCommandBufferMemBufferWrite

‎sycl/test/abi/pi_opencl_symbol_check.dump

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -83,9 +83,11 @@ piSamplerRetain
8383
piTearDown
8484
piextBindlessImageSamplerCreate
8585
piextCommandBufferCreate
86+
piextCommandBufferFillUSM
8687
piextCommandBufferFinalize
8788
piextCommandBufferMemBufferCopy
8889
piextCommandBufferMemBufferCopyRect
90+
piextCommandBufferMemBufferFill
8991
piextCommandBufferMemBufferRead
9092
piextCommandBufferMemBufferReadRect
9193
piextCommandBufferMemBufferWrite

‎sycl/test/abi/sycl_symbols_linux.dump

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3925,10 +3925,12 @@ _ZN4sycl3_V16detail13MemoryManager21copy_to_device_globalEPKvbSt10shared_ptrINS1
39253925
_ZN4sycl3_V16detail13MemoryManager23copy_from_device_globalEPKvbSt10shared_ptrINS1_10queue_implEEmmPvRKSt6vectorIP9_pi_eventSaISB_EEPSB_
39263926
_ZN4sycl3_V16detail13MemoryManager23copy_from_device_globalEPKvbSt10shared_ptrINS1_10queue_implEEmmPvRKSt6vectorIP9_pi_eventSaISB_EEPSB_RKS5_INS1_10event_implEE
39273927
_ZN4sycl3_V16detail13MemoryManager24allocateInteropMemObjectESt10shared_ptrINS1_12context_implEEPvRKS3_INS1_10event_implEERKS5_RKNS0_13property_listERP9_pi_event
3928+
_ZN4sycl3_V16detail13MemoryManager26ext_oneapi_fill_cmd_bufferESt10shared_ptrINS1_12context_implEEP22_pi_ext_command_bufferPNS1_11SYCLMemObjIEPvmPKcjNS0_5rangeILi3EEESE_NS0_2idILi3EEEjSt6vectorIjSaIjEEPj
39283929
_ZN4sycl3_V16detail13MemoryManager29ext_oneapi_copyD2D_cmd_bufferESt10shared_ptrINS1_12context_implEEP22_pi_ext_command_bufferPNS1_11SYCLMemObjIEPvjNS0_5rangeILi3EEESC_NS0_2idILi3EEEjSA_jSC_SC_SE_jSt6vectorIjSaIjEEPj
39293930
_ZN4sycl3_V16detail13MemoryManager29ext_oneapi_copyD2H_cmd_bufferESt10shared_ptrINS1_12context_implEEP22_pi_ext_command_bufferPNS1_11SYCLMemObjIEPvjNS0_5rangeILi3EEESC_NS0_2idILi3EEEjPcjSC_SE_jSt6vectorIjSaIjEEPj
39303931
_ZN4sycl3_V16detail13MemoryManager29ext_oneapi_copyH2D_cmd_bufferESt10shared_ptrINS1_12context_implEEP22_pi_ext_command_bufferPNS1_11SYCLMemObjIEPcjNS0_5rangeILi3EEENS0_2idILi3EEEjPvjSC_SC_SE_jSt6vectorIjSaIjEEPj
39313932
_ZN4sycl3_V16detail13MemoryManager30ext_oneapi_copy_usm_cmd_bufferESt10shared_ptrINS1_12context_implEEPKvP22_pi_ext_command_buffermPvSt6vectorIjSaIjEEPj
3933+
_ZN4sycl3_V16detail13MemoryManager30ext_oneapi_fill_usm_cmd_bufferESt10shared_ptrINS1_12context_implEEP22_pi_ext_command_bufferPvmiSt6vectorIjSaIjEEPj
39323934
_ZN4sycl3_V16detail13MemoryManager3mapEPNS1_11SYCLMemObjIEPvSt10shared_ptrINS1_10queue_implEENS0_6access4modeEjNS0_5rangeILi3EEESC_NS0_2idILi3EEEjSt6vectorIP9_pi_eventSaISH_EERSH_
39333935
_ZN4sycl3_V16detail13MemoryManager4copyEPNS1_11SYCLMemObjIEPvSt10shared_ptrINS1_10queue_implEEjNS0_5rangeILi3EEESA_NS0_2idILi3EEEjS5_S8_jSA_SA_SC_jSt6vectorIP9_pi_eventSaISF_EERSF_
39343936
_ZN4sycl3_V16detail13MemoryManager4copyEPNS1_11SYCLMemObjIEPvSt10shared_ptrINS1_10queue_implEEjNS0_5rangeILi3EEESA_NS0_2idILi3EEEjS5_S8_jSA_SA_SC_jSt6vectorIP9_pi_eventSaISF_EERSF_RKS6_INS1_10event_implEE

‎sycl/test/abi/sycl_symbols_windows.dump

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1041,6 +1041,8 @@
10411041
?ext_oneapi_empty@queue@_V1@sycl@@QEBA_NXZ
10421042
?ext_oneapi_enable_peer_access@device@_V1@sycl@@QEAAXAEBV123@@Z
10431043
?ext_oneapi_fill2d_impl@handler@_V1@sycl@@AEAAXPEAX_KPEBX111@Z
1044+
?ext_oneapi_fill_cmd_buffer@MemoryManager@detail@_V1@sycl@@SAXV?$shared_ptr@Vcontext_impl@detail@_V1@sycl@@@std@@PEAU_pi_ext_command_buffer@@PEAVSYCLMemObjI@234@PEAX_KPEBDIV?$range@$02@34@6V?$id@$02@34@IV?$vector@IV?$allocator@I@std@@@6@PEAI@Z
1045+
?ext_oneapi_fill_usm_cmd_buffer@MemoryManager@detail@_V1@sycl@@SAXV?$shared_ptr@Vcontext_impl@detail@_V1@sycl@@@std@@PEAU_pi_ext_command_buffer@@PEAX_KHV?$vector@IV?$allocator@I@std@@@6@PEAI@Z
10441046
?ext_oneapi_get_default_context@platform@_V1@sycl@@QEBA?AVcontext@23@XZ
10451047
?ext_oneapi_get_kernel@kernel_bundle_plain@detail@_V1@sycl@@QEAA?AVkernel@34@AEBV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@@Z
10461048
?ext_oneapi_get_state@queue@_V1@sycl@@QEBA?AW4queue_state@experimental@oneapi@ext@23@XZ

0 commit comments

Comments
 (0)