[SYCL] Support cl_khr_il_program extension

[alexbatashev]

clCreateProgramWithIL is used by SYCL, and this function is only available with OpenCL 2.1 or later. For OpenCL < 2.1 there is an extension cl_khr_il_program which makes the same function available under a different name: clCreateProgramWithILKHR. Make SYCL runtime check for its availability and use it.

Signed-off-by: Alexander Batashev [email protected]

[agozillon]

Out of interest do you think a similar method of querying the OpenCL runtime in use could be used for Queue creation: https://github.com/intel/llvm/blob/sycl/sycl/include/CL/sycl/detail/queue_impl.hpp#L145

And is this an alteration that might be done in the future? As I think that's one, if not the only location that still relies on the CL_VERSION_2_0 define at the moment. I've also had some small issues with it as the CL_VERSION_2_0 macro always seems to exist if you have an OpenCL > 2.0 compliant runtime when compiling, even if you intend to use something lower... Although, that may just be me doing something odd...

[bader]

Out of interest do you think a similar method of querying the OpenCL runtime in use could be used for Queue creation: https://github.com/intel/llvm/blob/sycl/sycl/include/CL/sycl/detail/queue_impl.hpp#L145

And is this an alteration that might be done in the future? As I think that's one, if not the only location that still relies on the CL_VERSION_2_0 define at the moment. I've also had some small issues with it as the CL_VERSION_2_0 macro always seems to exist if you have an OpenCL > 2.0 compliant runtime when compiling, even if you intend to use something lower... Although, that may just be me doing something odd...

I think we should do this.
@agozillon, do you have patches you would like to commit?
Today we test regularly on devices supporting OpenCL 2.1, but it's easy to skip usage of OpenCL 2.0+ API during the review/testing.
SYCL runtime is linked with ICD library and I don't know if we can build this library with OpenCL 1.2 support only. Last time I tried it failed.
I would really appreciate if you can help us to report/fix this kind of problems.

[agozillon]

Out of interest do you think a similar method of querying the OpenCL runtime in use could be used for Queue creation: https://github.com/intel/llvm/blob/sycl/sycl/include/CL/sycl/detail/queue_impl.hpp#L145
And is this an alteration that might be done in the future? As I think that's one, if not the only location that still relies on the CL_VERSION_2_0 define at the moment. I've also had some small issues with it as the CL_VERSION_2_0 macro always seems to exist if you have an OpenCL > 2.0 compliant runtime when compiling, even if you intend to use something lower... Although, that may just be me doing something odd...

I think we should do this.
@agozillon, do you have patches you would like to commit?
Today we test regularly on devices supporting OpenCL 2.1, but it's easy to skip usage of OpenCL 2.0+ API during the review/testing.
SYCL runtime is linked with ICD library and I don't know if we can build this library with OpenCL 1.2 support only. Last time I tried it failed.
I would really appreciate if you can help us to report/fix this kind of problems.

I sadly do not have a patch ready right now, I've got a dirty hack in place at the moment as a quick work around. However, I'd be happy to work on one but it may be a little while till I get around to it unfortunately.

Although this is one of the few locations I've had issues with OpenCL < 2.0 (the other being the invocation this pull request fixes), but if I find any others I will do my best to supply fixes for them in the future.