[SYCL] Drop sycl::exception::get_cl_code (#14400)

It was removed in SYCL 2020 and should be dropped during the current ABI
breaking window. We still need to access PI error code, either for
internal needs or for the backend interoperability, so the member field
remains. Also, introduce `sycl::detail::get_pi_error(const exception &)`
instead for internal needs (cache cleanup when out of resources only
currently).

Author: aelovikov-intel

sycl/include/sycl/exception.hpp

@@ -29,6 +29,7 @@ inline namespace _V1 {
 
 // Forward declaration
 class context;
+class exception;
 
 enum class errc : unsigned int {
   success = 0,
@@ -66,6 +67,9 @@ class __SYCL_EXPORT SYCLCategory : public std::error_category {
   const char *name() const noexcept override { return "sycl"; }
   std::string message(int) const override { return "SYCL Error"; }
 };
+
+// Forward declare to declare as a friend in sycl::excepton.
+__SYCL_EXPORT pi_int32 get_pi_error(const exception &e);
 } // namespace detail
 
 // Derive from std::exception so uncaught exceptions are printed in c++ default
@@ -110,9 +114,6 @@ class __SYCL_EXPORT exception : public virtual std::exception {
 
   context get_context() const;
 
-  __SYCL2020_DEPRECATED("use sycl::exception.code() instead.")
-  cl_int get_cl_code() const;
-
 private:
   // Exceptions must be noexcept copy constructible, so cannot use std::string
   // directly.
@@ -154,6 +155,8 @@ class __SYCL_EXPORT exception : public virtual std::exception {
   }
   exception(std::error_code Ec, std::shared_ptr<context> SharedPtrCtx,
             const char *WhatArg);
+
+  friend __SYCL_EXPORT pi_int32 detail::get_pi_error(const exception &);
 };
 
 class __SYCL2020_DEPRECATED(

sycl/source/detail/kernel_program_cache.hpp

@@ -289,7 +289,7 @@ class KernelProgramCache {
         return BuildResult;
       } catch (const exception &Ex) {
         BuildResult->Error.Msg = Ex.what();
-        BuildResult->Error.Code = Ex.get_cl_code();
+        BuildResult->Error.Code = detail::get_pi_error(Ex);
         if (BuildResult->Error.Code == PI_ERROR_OUT_OF_RESOURCES ||
             BuildResult->Error.Code == PI_ERROR_OUT_OF_HOST_MEMORY) {
           reset();

sycl/source/exception.cpp

@@ -83,8 +83,6 @@ context exception::get_context() const {
   return *MContext;
 }
 
-cl_int exception::get_cl_code() const { return MPIErr; }
-
 const std::error_category &sycl_category() noexcept {
   static const detail::SYCLCategory SYCLCategoryObj;
   return SYCLCategoryObj;
@@ -95,7 +93,9 @@ std::error_code make_error_code(sycl::errc Err) noexcept {
 }
 
 namespace detail {
-const char *stringifyErrorCode(pi_int32 error) {
+pi_int32 get_pi_error(const exception &e) { return e.MPIErr; }
+
+__SYCL_EXPORT const char *stringifyErrorCode(pi_int32 error) {
   switch (error) {
 #define _PI_ERRC(NAME, VAL)                                                    \
   case NAME:                                                                   \

sycl/test/abi/sycl_symbols_linux.dump

@@ -3232,6 +3232,7 @@ _ZN4sycl3_V16detail12buffer_plainC2ERKSt8functionIFvPvEEmmRKNS0_13property_listE
 _ZN4sycl3_V16detail12buffer_plainC2EmRKNS0_7contextESt10unique_ptrINS1_19SYCLMemObjAllocatorESt14default_deleteIS7_EEbRKNS0_5eventE
 _ZN4sycl3_V16detail12buffer_plainC2EmmRKNS0_13property_listESt10unique_ptrINS1_19SYCLMemObjAllocatorESt14default_deleteIS7_EE
 _ZN4sycl3_V16detail12compile_implERKNS0_13kernel_bundleILNS0_12bundle_stateE0EEERKSt6vectorINS0_6deviceESaIS8_EERKNS0_13property_listE
+_ZN4sycl3_V16detail12get_pi_errorERKNS0_9exceptionE
 _ZN4sycl3_V16detail12isOutOfRangeENS0_3vecIiLi4EEENS0_15addressing_modeENS0_5rangeILi3EEE
 _ZN4sycl3_V16detail12make_contextEmRKSt8functionIFvNS0_14exception_listEEENS0_7backendEbRKSt6vectorINS0_6deviceESaISA_EE
 _ZN4sycl3_V16detail13host_pipe_map3addEPKvPKc
@@ -4189,7 +4190,6 @@ _ZNK4sycl3_V18platform3getEv
 _ZNK4sycl3_V18platform3hasENS0_6aspectE
 _ZNK4sycl3_V18platform7is_hostEv
 _ZNK4sycl3_V18platform9getNativeEv
-_ZNK4sycl3_V19exception11get_cl_codeEv
 _ZNK4sycl3_V19exception11get_contextEv
 _ZNK4sycl3_V19exception11has_contextEv
 _ZNK4sycl3_V19exception4codeEv

sycl/test/abi/sycl_symbols_windows.dump

@@ -4195,7 +4195,6 @@
 ?get_backend@queue@_V1@sycl@@QEBA?AW4backend@23@XZ
 ?get_channel_order@image_mem@experimental@oneapi@ext@_V1@sycl@@QEBA?AW4image_channel_order@56@XZ
 ?get_channel_type@image_mem@experimental@oneapi@ext@_V1@sycl@@QEBA?AW4image_channel_type@56@XZ
-?get_cl_code@exception@_V1@sycl@@QEBAHXZ
 ?get_composite_devices@experimental@oneapi@ext@_V1@sycl@@YA?AV?$vector@Vdevice@_V1@sycl@@V?$allocator@Vdevice@_V1@sycl@@@std@@@std@@XZ
 ?get_context@exception@_V1@sycl@@QEBA?AVcontext@23@XZ
 ?get_context@image_mem@experimental@oneapi@ext@_V1@sycl@@QEBA?AVcontext@56@XZ
@@ -4241,6 +4240,7 @@
 ?get_node_from_event@node@experimental@oneapi@ext@_V1@sycl@@SA?AV123456@Vevent@56@@Z
 ?get_nodes@modifiable_command_graph@detail@experimental@oneapi@ext@_V1@sycl@@QEBA?AV?$vector@Vnode@experimental@oneapi@ext@_V1@sycl@@V?$allocator@Vnode@experimental@oneapi@ext@_V1@sycl@@@std@@@std@@XZ
 ?get_num_channels@image_mem@experimental@oneapi@ext@_V1@sycl@@QEBAIXZ
+?get_pi_error@detail@_V1@sycl@@YAHAEBVexception@23@@Z
 ?get_pipe_name@pipe_base@experimental@intel@ext@_V1@sycl@@KA?AV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@PEBX@Z
 ?get_pitch@image_plain@detail@_V1@sycl@@IEBA?AV?$range@$01@34@XZ
 ?get_platform@context@_V1@sycl@@QEBA?AVplatform@23@XZ

sycl/test/warnings/sycl_2020_deprecations.cpp

@@ -101,9 +101,6 @@ int main() {
   sycl::feature_not_supported fns;
   // expected-warning@+1{{'exception' is deprecated: The version of an exception constructor which takes no arguments is deprecated.}}
   sycl::exception ex;
-  // expected-warning@+1{{'get_cl_code' is deprecated: use sycl::exception.code() instead.}}
-  ex.get_cl_code();
-  (void)ex;
 
   // expected-warning@+1{{'online_compiler<sycl::ext::intel::experimental::source_language::opencl_c>' is deprecated}}
   sycl::ext::intel::experimental::online_compiler<