[SYCL] Drop sycl::exception::get_cl_code
#14400
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aelovikov-intel
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
It was removed in SYCL 2020 and should be dropped during the current ABI breaking window. We still need to access PI error code, either for internal needs or for the backend interoperability, so the member field remains. Also, introduce `sycl::detail::get_pi_error(const exception &)` instead for internal needs (cache cleanup when out of resources only currently).
aelovikov-intel
force-pushed
the
drop-get-cl-code
branch
from
c228b24 to
aefb2d3
Compare
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
commented
Jul 2, 2024
| @@ -66,6 +67,9 @@ class __SYCL_EXPORT SYCLCategory : public std::error_category { | |||
| const char *name() const noexcept override { return "sycl"; } | |||
| std::string message(int) const override { return "SYCL Error"; } | |||
| }; | |||
|
|
|||
| // Forward declare to declare as a friend in sycl::excepton. | |||
| __SYCL_EXPORT pi_int32 get_pi_error(const exception &e); | |||
There was a problem hiding this comment.
I'm not sure if it should be an exported symbol or inline header-only utility. Or, in other words (I think), if layout of sycl::exception is a part of ABI.
There was a problem hiding this comment.
We do have https://github.com/intel/llvm/blob/sycl/sycl/test/abi/layout_exception.cpp, but then it's unclear to me why get_cl_code wasn't an inline function...
cperkinsintel
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was removed in SYCL 2020 and should be dropped during the current ABI breaking window. We still need to access PI error code, either for internal needs or for the backend interoperability, so the member field remains. Also, introduce
sycl::detail::get_pi_error(const exception &)instead for internal needs (cache cleanup when out of resources only currently).