Skip to content

Commit 4151c79

Browse files
authored
[SYCL][Graph] Wait instead of flush dep events in update command (#14167)
- Could cause overlap of graph execution and initial h2d copy when updated with previously unused buffers - Re-enable update double buffer tests on CUDA as this should fix failures observed in #13731
1 parent 36c88dc commit 4151c79

File tree

3 files changed

+2
-6
lines changed

3 files changed

+2
-6
lines changed

sycl/source/detail/scheduler/commands.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3464,8 +3464,8 @@ UpdateCommandBufferCommand::UpdateCommandBufferCommand(
34643464
pi_int32 UpdateCommandBufferCommand::enqueueImp() {
34653465
waitForPreparedHostEvents();
34663466
std::vector<EventImplPtr> EventImpls = MPreparedDepsEvents;
3467-
auto RawEvents = getPiEvents(EventImpls);
3468-
flushCrossQueueDeps(EventImpls, getWorkerQueue());
3467+
sycl::detail::pi::PiEvent &Event = MEvent->getHandleRef();
3468+
Command::waitForEvents(MQueue, EventImpls, Event);
34693469

34703470
for (auto &Node : MNodes) {
34713471
auto CG = static_cast<CGExecKernel *>(Node->MCommandGroup.get());

sycl/test-e2e/Graph/Update/Explicit/whole_update_double_buffer.cpp

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,4 @@
77

88
#define GRAPH_E2E_EXPLICIT
99

10-
// UNSUPPORTED: cuda
11-
1210
#include "../../Inputs/whole_update_double_buffer.cpp"

sycl/test-e2e/Graph/Update/RecordReplay/whole_update_double_buffer.cpp

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,4 @@
77

88
#define GRAPH_E2E_RECORD_REPLAY
99

10-
// UNSUPPORTED: cuda
11-
1210
#include "../../Inputs/whole_update_double_buffer.cpp"

0 commit comments

Comments
 (0)