[SYCL][Graph] Wait instead of flush dep events in update command #14167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Bensuo
commented
Jun 13, 2024
Bensuo
commented
- Could cause overlap of graph execution and initial h2d copy when updated with previously unused buffers
- Re-enable update double buffer tests on CUDA as this should fix failures observed in whole_update_double_buffer.cpp failing in CI on CUDA #13731
- Could cause overlap of graph execution and initial h2d copy when updated with previously unused buffers - Re-enable update double buffer tests on CUDA
EwanC
approved these changes
Jun 14, 2024
|
@intel/llvm-reviewers-runtime Friendly ping for a review on this please! |
uditagarwal97
approved these changes
Jun 18, 2024
|
@intel/llvm-gatekeepers This is ready to merge, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.