Skip to content

Commit 43d5d14

Browse files
[SYCL] Remove debugging SYCL_THROW_ON_BLOCK env var (#7621)
The reasons for my suggestion to remove this var are: 1. Seems to be unused 2. The behavior is not clearly documented. 3. May indicate either incorrect sycl usage like 2+ host accessors blocking each other or fully correct behavior with host task usage
1 parent c493295 commit 43d5d14

File tree

3 files changed

+0
-45
lines changed

3 files changed

+0
-45
lines changed

sycl/doc/EnvironmentVariables.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -190,7 +190,6 @@ variables in production code.</span>
190190
| `SYCL_PRINT_EXECUTION_GRAPH` | Described [below](#sycl_print_execution_graph-options) | Print execution graph to DOT text file. |
191191
| `SYCL_DISABLE_EXECUTION_GRAPH_CLEANUP` | Any(\*) | Disable cleanup of finished command nodes at host-device synchronization points. |
192192
| `SYCL_DISABLE_POST_ENQUEUE_CLEANUP` | Any(\*) | Disable cleanup of enqueued command nodes during submission. |
193-
| `SYCL_THROW_ON_BLOCK` | Any(\*) | Throw an exception on attempt to wait for a blocked command. |
194193
| `SYCL_DEVICELIB_INHIBIT_NATIVE` | String of device library extensions (separated by a whitespace) | Do not rely on device native support for devicelib extensions listed in this option. |
195194
| `SYCL_PROGRAM_COMPILE_OPTIONS` | String of valid OpenCL compile options | Override compile options for all programs. |
196195
| `SYCL_PROGRAM_LINK_OPTIONS` | String of valid OpenCL link options | Override link options for all programs. |

sycl/source/detail/scheduler/commands.cpp

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -700,12 +700,6 @@ bool Command::enqueue(EnqueueResultT &EnqueueResult, BlockingT Blocking,
700700
EnqueueResult = EnqueueResultT(EnqueueResultT::SyclEnqueueBlocked, this);
701701
return false;
702702
}
703-
static bool ThrowOnBlock = getenv("SYCL_THROW_ON_BLOCK") != nullptr;
704-
if (ThrowOnBlock)
705-
throw sycl::runtime_error(
706-
std::string("Waiting for blocked command. Block reason: ") +
707-
std::string(getBlockReason()),
708-
PI_ERROR_INVALID_OPERATION);
709703

710704
#ifdef XPTI_ENABLE_INSTRUMENTATION
711705
// Scoped trace event notifier that emits a barrier begin and barrier end

sycl/test/scheduler/HostAcc.cpp

Lines changed: 0 additions & 38 deletions
This file was deleted.

0 commit comments

Comments
 (0)