Skip to content

[SYCL] Remove debugging SYCL_THROW_ON_BLOCK env var #7621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

KseniyaTikhomirova
Copy link
Contributor

Signed-off-by: Tikhomirova, Kseniya [email protected]

@KseniyaTikhomirova
Copy link
Contributor Author

KseniyaTikhomirova commented Dec 2, 2022

The reasons for my suggestion to remove this var are:

  1. seems to be unused
  2. have not clearly documented behavior and may indicate either incorrect sycl usage like 2+ host accessors blocking each other or fully correct behavior with host task usage
  3. when enabled it leads to behavior not aligned with sycl spec (no exception is expected in that case).

@KseniyaTikhomirova KseniyaTikhomirova marked this pull request as ready for review December 2, 2022 16:40
@KseniyaTikhomirova KseniyaTikhomirova requested review from a team as code owners December 2, 2022 16:40
@KseniyaTikhomirova
Copy link
Contributor Author

HIP failure is not related and present in different PRs.

@KseniyaTikhomirova
Copy link
Contributor Author

@intel/llvm-reviewers-runtime kindly ping

@romanovvlad romanovvlad merged commit 43d5d14 into intel:sycl Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants