Skip to content

[SYCL] Remove debugging SYCL_THROW_ON_BLOCK env var #7621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion sycl/doc/EnvironmentVariables.md
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,6 @@ variables in production code.</span>
| `SYCL_PRINT_EXECUTION_GRAPH` | Described [below](#sycl_print_execution_graph-options) | Print execution graph to DOT text file. |
| `SYCL_DISABLE_EXECUTION_GRAPH_CLEANUP` | Any(\*) | Disable cleanup of finished command nodes at host-device synchronization points. |
| `SYCL_DISABLE_POST_ENQUEUE_CLEANUP` | Any(\*) | Disable cleanup of enqueued command nodes during submission. |
| `SYCL_THROW_ON_BLOCK` | Any(\*) | Throw an exception on attempt to wait for a blocked command. |
| `SYCL_DEVICELIB_INHIBIT_NATIVE` | String of device library extensions (separated by a whitespace) | Do not rely on device native support for devicelib extensions listed in this option. |
| `SYCL_PROGRAM_COMPILE_OPTIONS` | String of valid OpenCL compile options | Override compile options for all programs. |
| `SYCL_PROGRAM_LINK_OPTIONS` | String of valid OpenCL link options | Override link options for all programs. |
Expand Down
6 changes: 0 additions & 6 deletions sycl/source/detail/scheduler/commands.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -700,12 +700,6 @@ bool Command::enqueue(EnqueueResultT &EnqueueResult, BlockingT Blocking,
EnqueueResult = EnqueueResultT(EnqueueResultT::SyclEnqueueBlocked, this);
return false;
}
static bool ThrowOnBlock = getenv("SYCL_THROW_ON_BLOCK") != nullptr;
if (ThrowOnBlock)
throw sycl::runtime_error(
std::string("Waiting for blocked command. Block reason: ") +
std::string(getBlockReason()),
PI_ERROR_INVALID_OPERATION);

#ifdef XPTI_ENABLE_INSTRUMENTATION
// Scoped trace event notifier that emits a barrier begin and barrier end
Expand Down
38 changes: 0 additions & 38 deletions sycl/test/scheduler/HostAcc.cpp

This file was deleted.