[SYCL] Fix stack corruption in sycl::modf for sycl::half type (#10535)

dm-vodopyanov · web-flow · commit 7c6541dc18e3 · 2023-07-25T16:59:22.000+02:00
diff --git a/sycl/source/detail/builtins_math.cpp b/sycl/source/detail/builtins_math.cpp
@@ -784,7 +784,10 @@ __SYCL_EXPORT s::cl_double sycl_host_modf(s::cl_double x,
 }
 __SYCL_EXPORT s::cl_half sycl_host_modf(s::cl_half x,
                                         s::cl_half *iptr) __NOEXC {
-  return std::modf(x, reinterpret_cast<s::cl_float *>(iptr));
+  float ptr_val_float = *iptr;
+  auto ret = std::modf(x, &ptr_val_float);
+  *iptr = ptr_val_float;
+  return ret;
 }
 MAKE_1V_2P(sycl_host_modf, s::cl_float, s::cl_float, s::cl_float)
 MAKE_1V_2P(sycl_host_modf, s::cl_double, s::cl_double, s::cl_double)

Original file line number	Diff line number	Diff line change
`@@ -784,7 +784,10 @@ __SYCL_EXPORT s::cl_double sycl_host_modf(s::cl_double x,`
`784`	`784`	`}`
`785`	`785`	`__SYCL_EXPORT s::cl_half sycl_host_modf(s::cl_half x,`
`786`	`786`	`s::cl_half *iptr) __NOEXC {`
`787`		`- return std::modf(x, reinterpret_cast<s::cl_float *>(iptr));`
	`787`	`+ float ptr_val_float = *iptr;`
	`788`	`+ auto ret = std::modf(x, &ptr_val_float);`
	`789`	`+ *iptr = ptr_val_float;`
	`790`	`+ return ret;`
`788`	`791`	`}`
`789`	`792`	`MAKE_1V_2P(sycl_host_modf, s::cl_float, s::cl_float, s::cl_float)`
`790`	`793`	`MAKE_1V_2P(sycl_host_modf, s::cl_double, s::cl_double, s::cl_double)`