Skip to content

Commit 98989d6

Browse files
authored
[NFC][Driver] Remove inadvertent append for the host link (#11922)
When performing the task involving early-AOT behaviors, an additional virtual function override of appendLinkHostActions was added, which was returning the end of the action list. This did not have an overall impact on the SYCL compilation flow, so it was unnoticed. When combining with the OpenMP interop offloading steps, this was causing an additional invalid object/device to be added to the host link. This can only be tested with the old offloading model, which only exists with the SYCL toolchain on the intel/llvm branch.
1 parent 219d4ef commit 98989d6

File tree

1 file changed

+0
-2
lines changed

1 file changed

+0
-2
lines changed

clang/lib/Driver/Driver.cpp

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5940,8 +5940,6 @@ class OffloadingActionBuilder final {
59405940
return NumOfDeviceLibLinked != 0;
59415941
}
59425942

5943-
Action *appendLinkHostActions(ActionList &AL) override { return AL.back(); }
5944-
59455943
void appendLinkDependences(OffloadAction::DeviceDependences &DA) override {
59465944
// DeviceLinkerInputs holds binaries per ToolChain (TC) / bound-arch pair
59475945
// The following will loop link and post process for each TC / bound-arch

0 commit comments

Comments
 (0)