[NFC][Driver] Remove inadvertent append for the host link #11922
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When performing the task involving early-AOT behaviors, an additional virtual function override of appendLinkHostActions was added, which was returning the end of the action list. This did not have an overall impact on the SYCL compilation flow, so it was unnoticed. When combining with the OpenMP interop offloading steps, this was causing an additional invalid object/device to be added to the host link. This can only be tested with the old offloading model, which only exists with the SYCL toolchain on the intel/llvm branch.
mdtoguchi
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
mdtoguchi
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
hchilama
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When performing the task involving early-AOT behaviors, an additional virtual function override of appendLinkHostActions was added, which was returning the end of the action list. This did not have an overall impact on the SYCL compilation flow, so it was unnoticed. When combining with the OpenMP interop offloading steps, this was causing an additional invalid object/device to be added to the host link.
This can only be tested with the old offloading model, which only exists with the SYCL toolchain on the intel/llvm branch.