Renaming the tablegen option based on offline discussion; NFC

Author: AaronBallman

clang/include/clang/Basic/Attr.td

@@ -317,13 +317,13 @@ class SubjectList<list<AttrSubject> subjects, SubjectDiag diag = WarnDiag,
   string CustomDiag = customDiag;
 }
 
-class LangOpt<string name, code customCode = [{}], bit warn = 1> {
+class LangOpt<string name, code customCode = [{}], bit silentlyIgnore = 0> {
   // The language option to test; ignored when custom code is supplied.
   string Name = name;
 
-  // If set to 0, the attribute is accepted but is silently ignored. This is
+  // If set to 1, the attribute is accepted but is silently ignored. This is
   // useful in multi-compilation situations like SYCL.
-  bit Warn = warn;
+  bit SilentlyIgnore = silentlyIgnore;
 
   // A custom predicate, written as an expression evaluated in a context with
   // "LangOpts" bound.
@@ -336,7 +336,7 @@ def HIP : LangOpt<"HIP">;
 def SYCL : LangOpt<"SYCL">;
 def SYCLIsDevice : LangOpt<"SYCLIsDevice">;
 def SYCLIsHost : LangOpt<"SYCLIsHost">;
-def SilentlyIgnoreSYCLIsHost : LangOpt<"SYCLIsHost", "", 0>;
+def SilentlyIgnoreSYCLIsHost : LangOpt<"SYCLIsHost", "", 1>;
 def SYCLExplicitSIMD : LangOpt<"SYCLExplicitSIMD">;
 def COnly : LangOpt<"", "!LangOpts.CPlusPlus">;
 def CPlusPlus : LangOpt<"CPlusPlus">;

clang/utils/TableGen/ClangAttrEmitter.cpp

@@ -1997,8 +1997,8 @@ static std::string GenerateTestExpression(ArrayRef<Record *> LangOpts,
   std::string Test;
 
   for (auto *E : LangOpts) {
-    bool LangOptWantsWarning = E->getValueAsBit("Warn");
-    if (LangOptWantsWarning != IsAttrAccepted)
+    bool SilentlyIgnore = E->getValueAsBit("SilentlyIgnore");
+    if (SilentlyIgnore == IsAttrAccepted)
       continue;
 
     if (!Test.empty())
@@ -2015,7 +2015,7 @@ static std::string GenerateTestExpression(ArrayRef<Record *> LangOpts,
             "non-empty 'Name' field ignored because 'CustomCode' was supplied");
       }
     } else {
-      if (!IsAttrAccepted && !LangOptWantsWarning)
+      if (!IsAttrAccepted && SilentlyIgnore)
         Test += "!";
       Test += "LangOpts.";
       Test += E->getValueAsString("Name");