Skip to content

Commit d795d73

Browse files
[SYCL][NFC] Make E2E more robust in different environments (#12625)
Adjusted `REQUIRES` clauses in SYCL E2E tests to better represent their requirements: those tests were either gated by wrong device types, or they were gated by specific HW identifier instead of an aspecto/optional feature. All changed tests fail in my local environment without the patch.
1 parent 25dcc20 commit d795d73

File tree

4 files changed

+4
-10
lines changed

4 files changed

+4
-10
lines changed

sycl/test-e2e/ESIMD/linear/linear.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
66
//
77
//===----------------------------------------------------------------------===//
8-
// UNSUPPORTED: gpu-intel-pvc
8+
// REQUIRES: aspect-ext_intel_legacy_image
99
// Use -O2 to avoid huge stack usage under -O0.
1010
// RUN: %{build} -O2 -I%S/.. -o %t.out
1111
// RUN: %{run} %t.out %S/linear_in.bmp %S/linear_gold_hw.bmp

sycl/test-e2e/InvokeSimd/Spec/simd_size/simd8.cpp

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
1-
// Test not intended to run on PVC
2-
// UNSUPPORTED: gpu-intel-pvc
3-
//
41
// REQUIRES-INTEL-DRIVER: lin: 26690, win: 101.4576
2+
// REQUIRES: sg-8
53
//
64
// Check that full compilation works:
75
// RUN: %{build} -fno-sycl-device-code-split-esimd -Xclang -fsycl-allow-func-ptr -o %t.out

sycl/test-e2e/KernelFusion/jit_caching_multispirv.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// REQUIRES: gpu, (opencl || level_zero)
1+
// REQUIRES: (gpu && (opencl || level_zero)), cpu
22
// RUN: %{build} -O2 -o %t.out
33
// RUN: env SYCL_RT_WARNING_LEVEL=1 %{run-unfiltered-devices} %t.out 2>&1 | FileCheck %s --implicit-check-not "WRONG a VALUE" --implicit-check-not "WRONG b VALUE"
44

sycl/test-e2e/KernelFusion/jit_caching_multitarget.cpp

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,6 @@
1-
// REQUIRES: gpu, (hip || cuda)
1+
// REQUIRES: (gpu && (hip || cuda)), cpu
22
// RUN: %{build} -fsycl-embed-ir -O2 -o %t.out
33
// RUN: env SYCL_RT_WARNING_LEVEL=1 %{run-unfiltered-devices} %t.out 2>&1 | FileCheck %s --implicit-check-not "WRONG a VALUE" --implicit-check-not "WRONG b VALUE"
4-
// XFAIL: *
5-
6-
// COM: This test is expected to fail on CI, as CUDA and HIP runners do not
7-
// provide a CPU backend.
84

95
// Test caching for JIT fused kernels when devices with different architectures
106
// are involved.

0 commit comments

Comments
 (0)