Skip to content

[SYCL][NFC] Make E2E more robust in different environments #12625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

AlexeySachkov
Copy link
Contributor

Adjusted REQUIRES clauses in SYCL E2E tests to better represent their requirements: those tests were either gated by wrong device types, or they were gated by specific HW identifier instead of an aspecto/optional feature.

All changed tests fail in my local environment without the patch.

Adjusted `REQUIRES` clauses in SYCL E2E tests to better represent their
requirements: those tests were either gated by wrong device types, or
they were gated by specific HW identifier instead of an aspecto/optional
feature.

All changed tests fail in my local environment without the patch.
@AlexeySachkov AlexeySachkov requested review from a team as code owners February 6, 2024 17:04
Copy link
Contributor

@sarnex sarnex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

esimd/invokesimd lgtm

Copy link
Contributor

@victor-eds victor-eds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

KernelFusion tests LGTM

@AlexeySachkov AlexeySachkov merged commit d795d73 into intel:sycl Feb 7, 2024
@AlexeySachkov AlexeySachkov deleted the private/asachkov/make-e2e-tests-more-robust branch May 22, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants