Skip to content

Commit f1b0bbe

Browse files
authored
[SYCL][UR] Fix include for COMGR (#12286)
The code object finalization for kernel fusion uses the AMD COMGR. The location of the corresponding header changed between ROCm version 4 and 5. This PR fixes the include for ROCm version 4. --------- Signed-off-by: Lukas Sommer <[email protected]>
1 parent 9ddb6d1 commit f1b0bbe

File tree

2 files changed

+21
-6
lines changed

2 files changed

+21
-6
lines changed

sycl/plugins/hip/CMakeLists.txt

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -134,6 +134,21 @@ if("${SYCL_BUILD_PI_HIP_PLATFORM}" STREQUAL "AMD")
134134
target_link_libraries(pi_hip PUBLIC rocmdrv)
135135

136136
if(SYCL_ENABLE_COMGR)
137+
set(PI_COMGR_VERSION5_HEADER "${PI_HIP_INCLUDE_DIR}/amd_comgr/amd_comgr.h")
138+
set(PI_COMGR_VERSION4_HEADER "${PI_HIP_INCLUDE_DIR}/amd_comgr.h")
139+
# The COMGR header changed location between ROCm version 4 and 5.
140+
# Check for the existence in the version 5 location or fallback to version 4
141+
if(NOT EXISTS "${PI_COMGR_VERSION5_HEADER}")
142+
if(NOT EXISTS "${PI_COMGR_VERSION4_HEADER}")
143+
message(FATAL_ERROR "Could not find AMD COMGR header at "
144+
"${PI_COMGR_VERSION5_HEADER} or "
145+
"${PI_COMGR_VERSION4_HEADER}, "
146+
"check ROCm installation")
147+
else()
148+
target_compile_definitions(pi_hip PRIVATE UR_COMGR_VERSION4_INCLUDE)
149+
endif()
150+
endif()
151+
137152
add_library(amd_comgr SHARED IMPORTED GLOBAL)
138153
set_target_properties(
139154
amd_comgr PROPERTIES

sycl/plugins/unified_runtime/CMakeLists.txt

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -57,13 +57,13 @@ if(SYCL_PI_UR_USE_FETCH_CONTENT)
5757
include(FetchContent)
5858

5959
set(UNIFIED_RUNTIME_REPO "https://github.com/oneapi-src/unified-runtime.git")
60-
# commit 1d7863601e9ecfffadf0617236a472a3b00fddbe
61-
# Merge: cf87428c 3ee71a71
60+
# commit c311fe82256a7bc7f6ddd19cb86c8d555ce401bc
61+
# Merge: eee75a29 d398d4ae
6262
# Author: Kenneth Benzie (Benie) <[email protected]>
63-
# Date: Thu Jan 4 11:03:26 2024 +0000
64-
# Merge pull request #938 from Bensuo/cmdbuf-fill-memset-l0
65-
# [EXP][CMDBUF] Implement Fill commands for L0 adapter
66-
set(UNIFIED_RUNTIME_TAG 1d7863601e9ecfffadf0617236a472a3b00fddbe)
63+
# Date: Thu Jan 4 15:12:54 2024 +0000
64+
# Merge pull request #1222 from sommerlukas/lukas/comgr-include-rocm4
65+
# [UR][HIP] Fix include for AMD COMGR
66+
set(UNIFIED_RUNTIME_TAG c311fe82256a7bc7f6ddd19cb86c8d555ce401bc)
6767

6868
if(SYCL_PI_UR_OVERRIDE_FETCH_CONTENT_REPO)
6969
set(UNIFIED_RUNTIME_REPO "${SYCL_PI_UR_OVERRIDE_FETCH_CONTENT_REPO}")

0 commit comments

Comments
 (0)