[SYCL][UR] Fix include for COMGR #12286
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sommerlukas
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
sommerlukas
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
sommerlukas
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
sommerlukas
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Signed-off-by: Lukas Sommer <[email protected]>
Signed-off-by: Lukas Sommer <[email protected]>
Signed-off-by: Lukas Sommer <[email protected]>
sommerlukas
force-pushed
the
comgr-include-rocm4
branch
from
8a11374 to
c11e4fd
Compare
sommerlukas
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
sommerlukas
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
kbenzie
reviewed
Jan 4, 2024
There was a problem hiding this comment.
oneapi-src/unified-runtime#1222 has now been merged, please update the UR tag as suggested, then make this PR ready for review.
Signed-off-by: Lukas Sommer <[email protected]>
kbenzie
approved these changes
Jan 4, 2024
sommerlukas
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
npmiller
approved these changes
Jan 4, 2024
sommerlukas
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
@intel/llvm-gatekeepers please merge. |
kbenzie
pushed a commit
that referenced
this pull request
Jan 5, 2024
The code object finalization for kernel fusion uses the AMD COMGR. The location of the corresponding header changed between ROCm version 4 and 5. This PR fixes the include for ROCm version 4. --------- Signed-off-by: Lukas Sommer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code object finalization for kernel fusion uses the AMD COMGR. The location of the corresponding header changed between ROCm version 4 and 5.
This PR fixes the include for ROCm version 4.