Use hasAlignment helper (#2856)

svenvh · jsji · commit ff9380bf4688 · 2024-11-22T14:48:47.000-08:00
Handle all queries of `Alignment` decorations through one and the same helper function. Original commit: KhronosGroup/SPIRV-LLVM-Translator@67685320c1192af
diff --git a/llvm-spirv/lib/SPIRV/SPIRVReader.cpp b/llvm-spirv/lib/SPIRV/SPIRVReader.cpp
@@ -3158,7 +3158,7 @@ void SPIRVToLLVM::transFunctionAttrs(SPIRVFunction *BF, Function *F) {
     if (BA->hasDecorate(DecorationMaxByteOffset, 0, &MaxOffset))
       Builder.addDereferenceableAttr(MaxOffset);
     SPIRVWord AlignmentBytes = 0;
-    if (BA->hasDecorate(DecorationAlignment, 0, &AlignmentBytes))
+    if (BA->hasAlignment(&AlignmentBytes))
       Builder.addAlignmentAttr(AlignmentBytes);
     I->addAttrs(Builder);
   }

Original file line number	Diff line number	Diff line change
`@@ -3158,7 +3158,7 @@ void SPIRVToLLVM::transFunctionAttrs(SPIRVFunction BF, Function F) {`
`3158`	`3158`	`if (BA->hasDecorate(DecorationMaxByteOffset, 0, &MaxOffset))`
`3159`	`3159`	`Builder.addDereferenceableAttr(MaxOffset);`
`3160`	`3160`	`SPIRVWord AlignmentBytes = 0;`
`3161`		`- if (BA->hasDecorate(DecorationAlignment, 0, &AlignmentBytes))`
	`3161`	`+ if (BA->hasAlignment(&AlignmentBytes))`
`3162`	`3162`	`Builder.addAlignmentAttr(AlignmentBytes);`
`3163`	`3163`	`I->addAttrs(Builder);`
`3164`	`3164`	`}`