Skip to content

[SYCL][NFC] Code cleanup (phase 2) revealed by self build. #2856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 4, 2020

Conversation

zahiraam
Copy link
Contributor

@zahiraam zahiraam commented Dec 3, 2020

No description provided.

Copy link
Contributor

@mdtoguchi mdtoguchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK for driver

Copy link
Contributor

@bader bader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

llvm/* changes looks okay to me.

Copy link
Contributor

@premanandrao premanandrao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SemaSYCL change looks good to me.

@bader bader merged commit 0cf42f2 into intel:sycl Dec 4, 2020
@zahiraam zahiraam deleted the code-cleanup-2 branch February 7, 2022 15:27
jsji pushed a commit that referenced this pull request Nov 22, 2024
Handle all queries of `Alignment` decorations through one and the same
helper function.

Original commit:
KhronosGroup/SPIRV-LLVM-Translator@67685320c1192af
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants