[SYCL][ABI-Break][PI] Remove deprecated piEnqueueNativeKernel #10008
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbenzie
force-pushed
the
benie/remove-piEnqueueNativeKernel
branch
from
b161682 to
0f80414
Compare
kbenzie
force-pushed
the
benie/remove-piEnqueueNativeKernel
branch
from
0f80414 to
8d31103
Compare
jandres742
approved these changes
Jun 23, 2023
kbenzie
force-pushed
the
benie/remove-piEnqueueNativeKernel
branch
from
8d31103 to
d78ef2e
Compare
kbenzie
force-pushed
the
benie/remove-piEnqueueNativeKernel
branch
from
d78ef2e to
5d0c95d
Compare
sergey-semenov
approved these changes
Jul 6, 2023
This patch removes the deprecated entry-point `piEnqueueNativeKernel`. This change is being made in preparation for porting the OpenCL plugin to Unified Runtime which does not intend to support enqueuing native kernels since it has already being deprecated.
kbenzie
force-pushed
the
benie/remove-piEnqueueNativeKernel
branch
from
5d0c95d to
98015ba
Compare
|
@intel/dpcpp-esimd-reviewers a review would be much appriciated, thanks. |
kbenzie
changed the title
|
@intel/dpcpp-esimd-reviewers ping to review this please. The relevant changes are very small, removal of an unimplemented function in sycl/plugins/esimd_emulator/pi_esimd_emulator.cpp. This is also pretty urgent since this PR contains ABI breaking changes and the merge deadline is looming. |
|
@intel/llvm-gatekeepers this is now ready to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch removes the deprecated entry-point
piEnqueueNativeKernel.This change is being made in preparation for porting the OpenCL plugin
to Unified Runtime which does not intend to support enqueuing native
kernels since it has already being deprecated.