Skip to content

[SYCL][E2E] Fix allowlist test by removing special characters from the regex. #10030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 29, 2023

Conversation

fabiomestre
Copy link
Contributor

Some device names can contain square brackets. This was making the regex generated by the allowlist test invalid. This commit removes the square brakets from the generated regex.

…e regex.

Some device names can contain square brackets. This was making the regex generated by the
 allowlist test invalid. This commit removes the square brakets from the generated regex.
@fabiomestre fabiomestre temporarily deployed to aws June 22, 2023 13:09 — with GitHub Actions Inactive
@fabiomestre fabiomestre temporarily deployed to aws June 22, 2023 13:40 — with GitHub Actions Inactive
@fabiomestre fabiomestre marked this pull request as ready for review June 28, 2023 11:58
@fabiomestre fabiomestre requested a review from a team as a code owner June 28, 2023 11:58
Copy link
Contributor

@steffenlarsen steffenlarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@steffenlarsen
Copy link
Contributor

Failing tests were untouched and has since been fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants