[SYCL] Fix segfault upon initial complex call to set_final_data(null) #1004
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romanovvlad
previously approved these changes
Jan 13, 2020
romanovvlad
reviewed
Jan 13, 2020
mlychkov
reviewed
Jan 14, 2020
A complex call is: -- snip start -- char *ptr = reinterpret_cast<char *>(nullptr); sycl_obj.set_final_data(ptr); -- snip end -- Signed-off-by: Sergey Kanaev <[email protected]>
Signed-off-by: Sergey Kanaev <[email protected]>
Co-Authored-By: Mikhail Lychkov <[email protected]> Signed-off-by: Sergey Kanaev <[email protected]>
s-kanaev
force-pushed
the
private/s-kanaev/fix-segfault
branch
from
37f727b to
4a85d31
Compare
AlexeySachkov
approved these changes
Jan 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A complex call is:
-- snip start --
char *ptr = reinterpret_cast<char *>(nullptr);
sycl_obj.set_final_data(ptr);
-- snip end --
Signed-off-by: Sergey Kanaev [email protected]