[SYCL] Replace std::true/false_t by std::true/false_type. #10068
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maronas, Marcos <[email protected]>
steffenlarsen
approved these changes
Jun 26, 2023
bader
reviewed
Jun 26, 2023
| @@ -141,7 +141,7 @@ struct all_devices_have<aspect::ext_intel_legacy_image> | |||
|
|
|||
| #ifdef __SYCL_ANY_DEVICE_HAS_ANY_ASPECT__ | |||
| // Special case where any_device_has is trivially true. | |||
| template <aspect Aspect> struct any_device_has : std::true_t {}; | |||
| template <aspect Aspect> struct any_device_has : std::true_type {}; | |||
There was a problem hiding this comment.
We use undefined type, and no tests detects this!?!
There was a problem hiding this comment.
This implementation was intended as base work for upcoming patches. The path could not previously be hit, unless someone from the outside defined the macro, so it was not actually an issue.
There was a problem hiding this comment.
Okay. Please, make sure it's covered with tests in "upcoming patches".
0x12CC
approved these changes
Jun 26, 2023
Chenyang-L
pushed a commit
that referenced
this pull request
Jul 11, 2023
`std::true_t` and `std::false_t` don't exist, the correct ones are `std::true_type` and `std::false_type`. Signed-off-by: Maronas, Marcos <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
std::true_tandstd::false_tdon't exist, the correct ones arestd::true_typeandstd::false_type.