[SYCL][ESIMD] Add new raw_send APIs moving compile time params to template params #10167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll be on vacation until July 26th, I'll address any feedback then. Thanks! |
|
I suggest using a simpler approach that does not require adding new _esimd* internal intrinsics. template <uint32_t SLMSize> __ESIMD_API void slm_init() {
__esimd_slm_init(SLMSize);
} |
|
Good idea, I didn't consider using template params into arguments to the intrinsic that accepts runtime params, thanks, let me try! |
… template arguments The arguments moved from runtime params to template params need to be compile time constant. Often they end up as compile time constant after constant folding, but not in all cases such as -O0, which will lead to an IGC error. Add new APIs to enforce this requirement. I also updated three LSC APIs to use the new version, but these were already passing in constexpr arguments. Signed-off-by: Sarnie, Nick <[email protected]>
Signed-off-by: Sarnie, Nick <[email protected]>
|
BTW I manually verified the issue is fixed with the latest version of this change if you use the new API. |
turinevgeny
reviewed
Jul 27, 2023
v-klochkov
reviewed
Jul 27, 2023
Signed-off-by: Sarnie, Nick <[email protected]>
v-klochkov
approved these changes
Jul 28, 2023
mdtoguchi
pushed a commit
to mdtoguchi/llvm
that referenced
this pull request
Oct 18, 2023
…plate params (intel#10167) The arguments moved from runtime params to template params need to be compile time constant. Often they end up as compile time constant after constant folding, but not in all cases such as -O0, and if they are not constant it will lead to an IGC error. Add new APIs to enforce this requirement. I also updated three LSC APIs to use the new version, but these were already passing in constexpr arguments. --------- Signed-off-by: Sarnie, Nick <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The arguments moved from runtime params to template params need to be compile time constant.
Often they end up as compile time constant after constant folding, but not in all cases such as -O0, and if they are not constant it will lead to an IGC error.
Add new APIs to enforce this requirement.
I also updated three LSC APIs to use the new version, but these were already passing in constexpr arguments.