[SYCL][FPGA] Changing the attribute max_private_copies to private_cop… #1024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The SPIRV coming out of the translator does not change. The SPIRV decoration is still MaxPrivateCopies. This should probably be fixed in the future (starting with the SPIRV spec) for consistency. Signed-off-by: Mohammad Fawaz <[email protected]>
mohammadfawaz
force-pushed
the
change_max_pc_clang
branch
from
923ea53 to
1023db5
Compare
AGindinson
approved these changes
Jan 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ies.
The SPIRV coming out of the translator does not change. The SPIRV
decoration is still MaxPrivateCopies. This should probably be fixed in
the future (starting with the SPIRV spec) for consistency.
Signed-off-by: Mohammad Fawaz [email protected]