Skip to content

[sycl-post-link][NFC] Check for empty result after ESIMD split #10255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 7, 2023
Merged

[sycl-post-link][NFC] Check for empty result after ESIMD split #10255

merged 1 commit into from
Jul 7, 2023

Conversation

vmaksimo
Copy link
Contributor

@vmaksimo vmaksimo commented Jul 6, 2023

No description provided.

@vmaksimo vmaksimo temporarily deployed to aws July 6, 2023 18:51 — with GitHub Actions Inactive
@vmaksimo vmaksimo temporarily deployed to aws July 6, 2023 20:16 — with GitHub Actions Inactive
@vmaksimo
Copy link
Contributor Author

vmaksimo commented Jul 7, 2023

Is it possible that the failure is not related to the change? I can't reproduce it locally, the test passes on CPU

@vmaksimo vmaksimo marked this pull request as ready for review July 7, 2023 13:35
@vmaksimo vmaksimo requested a review from a team as a code owner July 7, 2023 13:35
@AlexeySachkov
Copy link
Contributor

Is it possible that the failure is not related to the change? I can't reproduce it locally, the test passes on CPU

Your patch doesn't contain any functional changes, it can't cause any failures.

It seems to me that we may have a bug somewhere in our CI, which causes some de-sync between SYCL RT and SYCL E2E tests. For example, in this particular case CI used old version of the test and newer version of SYCL RT, which caused fail.

@AlexeySachkov AlexeySachkov merged commit aac3cd1 into intel:sycl Jul 7, 2023
@bader
Copy link
Contributor

bader commented Jul 7, 2023

Is it possible that the failure is not related to the change? I can't reproduce it locally, the test passes on CPU

Your patch doesn't contain any functional changes, it can't cause any failures.

It seems to me that we may have a bug somewhere in our CI, which causes some de-sync between SYCL RT and SYCL E2E tests. For example, in this particular case CI used old version of the test and newer version of SYCL RT, which caused fail.

@AlexeySachkov, please, open an issue to investigate.
@aelovikov-intel, FYI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexeySachkov AlexeySachkov AlexeySachkov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vmaksimo @AlexeySachkov @bader