Fix offload extract #10257
Merged
Fix offload extract #10257
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dseynhae
commented
Jul 6, 2023
dseynhae
commented
- More comments for maintainability.
- Extract relevant sections up front to speed up the embedded binary search.
- Provide better diagnostics (especially providing info on the result files).
- Fix code to work on Windows (COFF files).
|
Looks like there is an issue with the Windows variant of the LIT test. |
asudarsa
reviewed
Jul 9, 2023
| // metadata on the embedded binaries) | ||
| unsigned FileNum = 0; | ||
|
|
||
| // * Create an array all the sections that have |
There was a problem hiding this comment.
Suggested change
| // * Create an array all the sections that have | |
| // * Create an array of all the sections that have |
asudarsa
reviewed
Jul 9, 2023
mdtoguchi
reviewed
Jul 26, 2023
|
Hi @againull This change seems good to go. Can you please take a look at this and merge if everything looks ok? The test failure is something we are not able to figure why it's happening. But, it does not seem to be caused by this PR. Thanks |
mdtoguchi
pushed a commit
to mdtoguchi/llvm
that referenced
this pull request
Oct 18, 2023
- More comments for maintainability. - Extract relevant sections up front to speed up the embedded binary search. - Provide better diagnostics (especially providing info on the result files). - Fix code to work on Windows (COFF files). --------- Co-authored-by: Ejjeh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.