Skip to content

[SPIR-V][Driver] Turn on SPV extension SPV_INTEL_fpga_latency_control in the clang driver #10268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 13, 2023
Merged

[SPIR-V][Driver] Turn on SPV extension SPV_INTEL_fpga_latency_control in the clang driver #10268

merged 1 commit into from
Jul 13, 2023

Conversation

asudarsa
Copy link
Contributor

@asudarsa asudarsa commented Jul 7, 2023

SPIR-V Spec change is here: KhronosGroup/SPIRV-Registry#179
This support is now ready to be turned on by default in the clang driver.

Thanks

@asudarsa asudarsa requested a review from a team as a code owner July 7, 2023 17:12
@asudarsa asudarsa temporarily deployed to aws July 7, 2023 17:29 — with GitHub Actions Inactive
@asudarsa asudarsa temporarily deployed to aws July 7, 2023 18:09 — with GitHub Actions Inactive
mdtoguchi
mdtoguchi approved these changes Jul 8, 2023
View reviewed changes
Copy link
Contributor

@mdtoguchi mdtoguchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@asudarsa
Copy link
Contributor Author

asudarsa commented Jul 9, 2023

The CUDA test failures do not seem to be related to my change. Adding @intel/llvm-reviewers-cuda and @MrSidims for comment here.

Thanks

@dm-vodopyanov
Copy link
Contributor

@asudarsa please, follow https://github.com/intel/llvm/blob/sycl/sycl/doc/developer/ContributeToDPCPP.md#commit-message for

@asudarsa asudarsa changed the title Turn on SPV extension SPV_INTEL_fpga_latency_control in the clang driver [Driver] Turn on SPV extension SPV_INTEL_fpga_latency_control in the clang driver Jul 12, 2023
@asudarsa asudarsa changed the title [Driver] Turn on SPV extension SPV_INTEL_fpga_latency_control in the clang driver [SPIR-V][Driver] Turn on SPV extension SPV_INTEL_fpga_latency_control in the clang driver Jul 12, 2023
@dm-vodopyanov dm-vodopyanov merged commit 1aabcf8 into intel:sycl Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdtoguchi mdtoguchi mdtoguchi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@asudarsa @dm-vodopyanov @mdtoguchi