[SYCL][NFC] Eliminate struct/class definition/declaration and static/static-inlined function warnings. #1027
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s-kanaev
changed the title
|
Please, add |
bader
reviewed
Jan 20, 2020
bader
changed the title
added 5 commits
January 23, 2020 13:40
…finition and declaration to avoid compiler warnings Compiling user code with -Wall provides compilation warnings from SYCL headers. In some cases (-Werror or smth like that is enabled) it may not allow to compile user code. ``` CL/sycl/detail/generic_type_traits.hpp:468:1: warning: 'TryToGetNumElements' defined as a struct template here but previously declared as a class template; this is valid, but may result in linker errors under the Microsoft C++ ABI [-Wmismatched-tags] struct TryToGetNumElements< ``` Signed-off-by: Sergey Kanaev <[email protected]>
Signed-off-by: Sergey Kanaev <[email protected]>
Signed-off-by: Sergey Kanaev <[email protected]>
Signed-off-by: Sergey Kanaev <[email protected]>
Signed-off-by: Sergey Kanaev <[email protected]>
s-kanaev
force-pushed
the
private/s-kanaev/warnings
branch
from
ffab137 to
1a009d2
Compare
Done. |
bader
reviewed
Jan 23, 2020
Signed-off-by: Sergey Kanaev [email protected] Co-Authored-By: Alexey Bader <[email protected]>
|
@asavonic It's your time to act, now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compiling user code with -Wall provides compilation warnings from SYCL headers.
In some cases (-Werror or smth like that is enabled) it may not allow to compile user code.
It's common to #983
Also, a multiple of:
warnings was eliminated.
Signed-off-by: Sergey Kanaev [email protected]