[SYCL] Diagnose invalid data types in image accessor #1029
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexeySachkov
requested changes
Jan 20, 2020
bader
reviewed
Jan 20, 2020
bader
reviewed
Jan 20, 2020
s-kanaev
reviewed
Jan 21, 2020
sycl/include/CL/sycl/accessor.hpp
Outdated
Comment on lines
318
to
319
| "The data type of an image accessor must be only cl_int4, " | ||
| "cl_uint4, cl_float4 or cl_half4 from SYCL namespace"); |
There was a problem hiding this comment.
Looks like you have some spare spaces here in front of string.
There was a problem hiding this comment.
Thanks for suggestion, I applied clang-format here.
garimagu
reviewed
Jan 21, 2020
imashkov
changed the title
bader
changed the title
bader
previously approved these changes
Jan 24, 2020
s-kanaev
previously approved these changes
Jan 24, 2020
The data type for the accessor of image should be half4, float4, uint4 or int4 from SYCL namespace. This patch report error, if data type is invalid. Signed-off-by: Ilya Mashkov [email protected]
AlexeySachkov
approved these changes
Jan 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The data type for the accessor of image should be half4, float4, uint4 or int4. This patch report error, if data type is invalid.
Signed-off-by: Ilya Mashkov [email protected]