[SYCL] Refactor sub-group built-ins implementation #1031
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexeySachkov
requested review from
rolandschulz,
Pennycook,
KarachunIvan and
s-kanaev
AlexeySachkov
force-pushed
the
private/asachkov/refactor-sub-group-bis
branch
from
b49339d to
04f6bd0
Compare
AGindinson
reviewed
Jan 21, 2020
s-kanaev
reviewed
Jan 21, 2020
Pennycook
reviewed
Jan 21, 2020
AlexeySachkov
commented
Jan 22, 2020
AlexeySachkov
force-pushed
the
private/asachkov/refactor-sub-group-bis
branch
from
1e8adb3 to
3898c75
Compare
keryell
reviewed
Jan 23, 2020
AlexeySachkov
force-pushed
the
private/asachkov/refactor-sub-group-bis
branch
from
3898c75 to
9af42e4
Compare
Main motivation and idea of this change is to use existing utility functions for mapping from SYCL types to corresponding SPIR-V types, which will automatically allows to use wide range of types in sub-group built-ins (like `char` or `bool`) List of changes: - used existing `ConvertToOpenCLType_t` to map SYCL types to OpenCL types - added bunch of helper functions to reduce the code - refactored bunch of `enable_if`s to use the same style (on return value) Signed-off-by: Alexey Sachkov <[email protected]>
AlexeySachkov
force-pushed
the
private/asachkov/refactor-sub-group-bis
branch
from
9af42e4 to
c04ede2
Compare
KarachunIvan
approved these changes
Jan 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main motivation and idea of this change is to use existing utility
functions for mapping from SYCL types to corresponding SPIR-V types,
which will automatically allows to use wide range of types in sub-group
built-ins (like
charorbool)List of changes:
ConvertToOpenCLType_tto map SYCL types to OpenCLtypes
enable_ifs to use the same style (on returnvalue)