Skip to content

[SYCL][Ordered Queue] Begin moving ordered_queue to be a property on the queue. #1035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Feb 4, 2020
Merged

[SYCL][Ordered Queue] Begin moving ordered_queue to be a property on the queue. #1035

merged 6 commits into from
Feb 4, 2020

Conversation

jbrodman
Copy link
Contributor

Can deprecate ordered_queue in the future. Preserve now to now break codes that might use it.

Signed-off-by: James Brodman [email protected]

@jbrodman jbrodman requested a review from bader January 21, 2020 21:58
bader
bader reviewed Jan 22, 2020
View reviewed changes
bader
bader reviewed Jan 22, 2020
View reviewed changes
Copy link
Contributor

@bader bader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can deprecate ordered_queue in the future.

I think it make sense. If you are not going to remove it right away, I suggest adding [[deprecated]] attribute to orderd_queue declaration (under __has_cpp_attribute(deprecated) check as it's C++14 feature).

@bader bader requested a review from Pennycook January 22, 2020 14:39
Pennycook
Pennycook reviewed Jan 22, 2020
View reviewed changes
bader
bader reviewed Jan 22, 2020
View reviewed changes
bader
bader previously approved these changes Jan 23, 2020
View reviewed changes
Copy link
Contributor

@bader bader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

Pennycook
Pennycook previously approved these changes Jan 23, 2020
View reviewed changes
romanovvlad
romanovvlad reviewed Jan 27, 2020
View reviewed changes
@jbrodman
Simplify is_in_order
b888532 
Signed-off-by: James Brodman <[email protected]>
@jbrodman jbrodman requested review from romanovvlad and bader January 27, 2020 14:36
@jbrodman
Remove unused forward decl.
c9814a6 
Signed-off-by: James Brodman <[email protected]>
bader
bader previously approved these changes Feb 3, 2020
View reviewed changes
@jbrodman
Copy link
Contributor Author

jbrodman commented Feb 3, 2020

I have no idea why tests are failing. They pass on my systems.

bader
bader reviewed Feb 4, 2020
View reviewed changes
@jbrodman
Fix link error
b5cad7e 
Signed-off-by: James Brodman <[email protected]>
@jbrodman jbrodman requested a review from bader February 4, 2020 10:45
@bader bader merged commit c855520 into intel:sycl Feb 4, 2020
@jbrodman jbrodman mentioned this pull request Feb 6, 2020
Closed
@jbrodman jbrodman mentioned this pull request Feb 13, 2020
Closed
@abagusetty abagusetty mentioned this pull request Apr 23, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bader bader bader approved these changes

@Pennycook Pennycook Pennycook left review comments

@romanovvlad romanovvlad Awaiting requested review from romanovvlad

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jbrodman @bader @Pennycook @romanovvlad