[SPIR-V][OpaquePointers] Temporary workaround for IGC issue. #10407
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IGC has some issues with reverse translation of SPIR-V builtins resulting from code compiled with opaque pointers enabled. To enable opaque pointers to be enabled for offloaded code before the new driver version is propagated to CI, this change is temporarily necessary to ensure we have test coverage.
bader
approved these changes
Jul 14, 2023
There was a problem hiding this comment.
LGTM.
It a bit concerning that we apply this work-around unconditionally and may affect non-GPU devices, but I hope IGC team will fix this issue soon and we remove this work-around. Probably it's a good idea to add some test to detect if the issue is fixed on GPU, so we get a notification that this workaround is not needed anymore.
MrSidims
approved these changes
Jul 18, 2023
ldrumm
pushed a commit
that referenced
this pull request
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IGC has some issues with reverse translation of SPIR-V builtins resulting from code compiled with opaque pointers enabled. To enable opaque pointers to be enabled for offloaded code before the new driver version is propagated to CI, this change is temporarily necessary to ensure we have test coverage.