Skip to content

[SYCL][doc][NFC] Update doc and usage of -fsycl-device-obj #10432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 20, 2023

Conversation

mdtoguchi
Copy link
Contributor

The -fsycl-device-obj option replaces the -fsycl-use-bitcode option. The -fsycl-use-bitcode option is deprecated as well. Update the documentation to reflect this fact, also update any testing using the older option with a replacement of the new option.

The use of -fsycl-use-bitcode should also emit the proper deprecation message when used on the command line.

The -fsycl-device-obj option replaces the -fsycl-use-bitcode option.
The -fsycl-use-bitcode option is deprecated as well.  Update the
documentation to reflect this fact, also update any testing using the
older option with a replacement of the new option.

The use of -fsycl-use-bitcode should also emit the proper deprecation
message when used on the command line.
Copy link
Contributor

@steffenlarsen steffenlarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs changes LGTM!

Copy link
Contributor

@hchilama hchilama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mdtoguchi mdtoguchi temporarily deployed to aws July 19, 2023 12:24 — with GitHub Actions Inactive
@mdtoguchi mdtoguchi temporarily deployed to aws July 19, 2023 16:58 — with GitHub Actions Inactive
@mdtoguchi mdtoguchi temporarily deployed to aws July 19, 2023 17:56 — with GitHub Actions Inactive
@mdtoguchi
Copy link
Contributor Author

@intel/llvm-gatekeepers, Can you look this over for merging? Failing items are not relevant to my changes.

@aelovikov-intel
Copy link
Contributor

Failure log for future references/searches:

TIMEOUT: SYCL :: BitonicSortK_emu.cpp ([34](https://github.com/intel/llvm/actions/runs/5578936450/job/15176137323?pr=10432#step:17:35)1 of [35](https://github.com/intel/llvm/actions/runs/5578936450/job/15176137323?pr=10432#step:17:36)0)
******************** TEST 'SYCL :: BitonicSortK_emu.cpp' FAILED ********************
Script:
--
: 'RUN: at line 9';    /__w/llvm/llvm/toolchain/bin//clang++   -fsycl -fsycl-targets=spir64 /__w/llvm/llvm/llvm/sycl/test-e2e/ESIMD/BitonicSortK_emu.cpp -o /__w/llvm/llvm/build-e2e/ESIMD/Output/BitonicSortK_emu.cpp.tmp.out
: 'RUN: at line 10';   env CM_RT_PLATFORM=skl ONEAPI_DEVICE_SELECTOR=ext_intel_esimd_emulator:gpu  /__w/llvm/llvm/build-e2e/ESIMD/Output/BitonicSortK_emu.cpp.tmp.out
--
Exit Code: -9
Timeout: Reached timeout of 600 seconds

Command Output (stdout):
--
$ ":" "RUN: at line 9"
note: command had no output on stdout or stderr
$ "/__w/llvm/llvm/toolchain/bin//clang++" "-fsycl" "-fsycl-targets=spir64" "/__w/llvm/llvm/llvm/sycl/test-e2e/ESIMD/BitonicSortK_emu.cpp" "-o" "/__w/llvm/llvm/build-e2e/ESIMD/Output/BitonicSortK_emu.cpp.tmp.out"
note: command had no output on stdout or stderr
$ ":" "RUN: at line 10"
note: command had no output on stdout or stderr
$ "env" "CM_RT_PLATFORM=skl" "ONEAPI_DEVICE_SELECTOR=ext_intel_esimd_emulator:gpu" "/__w/llvm/llvm/build-e2e/ESIMD/Output/BitonicSortK_emu.cpp.tmp.out"
# command output:
BitonicSort (655[36](https://github.com/intel/llvm/actions/runs/5578936450/job/15176137323?pr=10432#step:17:37)) Start...

error: command failed with exit status: -9
error: command reached timeout: True

@aelovikov-intel aelovikov-intel merged commit 1a52f1a into intel:sycl Jul 20, 2023
mdtoguchi added a commit to mdtoguchi/llvm that referenced this pull request Oct 18, 2023
The -fsycl-device-obj option replaces the -fsycl-use-bitcode option. The
-fsycl-use-bitcode option is deprecated as well. Update the
documentation to reflect this fact, also update any testing using the
older option with a replacement of the new option.

The use of -fsycl-use-bitcode should also emit the proper deprecation
message when used on the command line.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants