Skip to content

[SYCL] Coverity bug fix #10446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 19 commits into from
Closed

[SYCL] Coverity bug fix #10446

wants to merge 19 commits into from

Conversation

eunakim0103
Copy link
Contributor

Coverity reported following three issues and fixed with adding a copy constructor & assignment operator, and removing dead code.

  1. Logically dead code
  2. Missing assignment operator
  3. Copy without assign

euna.kim and others added 19 commits June 26, 2023 21:22
[SYCL] change the behavior of sycl::maximum and sycl::minimum to be c…
d48a512 
…onsistent with std::max and std::min
@eunakim0103
[SYCL] change the behavior of sycl::maximum and sycl::minimum to be c…
a1c1205 
…onsistent with std::max and std::min
@eunakim0103
[SYCL] change the behavior of sycl::maximum and sycl::minimum to be c…
6aaf3c9 
…onsistent with std::max and std::min
@eunakim0103
[SYCL] change the behavior of sycl::maximum and sycl::minimum to be c…
000adf4 
…onsistent with std::max and std::min
@eunakim0103
[SYCL] change the behavior of sycl::maximum and sycl::minimum to be c…
84ae02b 
…onsistent with std::max and std::min
@eunakim0103
[SYCL] change the behavior of sycl::maximum and sycl::minimum to be c…
58907b0 
…onsistent with std::max and std::min
@eunakim0103
Merge remote-tracking branch 'intel/sycl' into sycl_min_max
faa7c2a
@eunakim0103
Merge remote-tracking branch 'intel/sycl' into sycl_min_max
65f7461
@eunakim0103
change the execution command in lit test file
740ab1b
@eunakim0103
change the RUN parameter in the lit test file
1ec6361
@eunakim0103
fix the binary generation for the lit test and fixed comment
de9f2e6 
Signed-off-by: Kim, Euna <[email protected]>
@eunakim0103
removing -fsyntax-only from command
3d161a9 
Signed-off-by: Kim, Euna <[email protected]>
@eunakim0103
fixed comments and format
6d857c0 
Signed-off-by: Kim, Euna <[email protected]>
@eunakim0103
fixed to follow the SYCL2020 namespace standard
e8012fb 
Signed-off-by: Kim, Euna <[email protected]>
@eunakim0103
fixed the order in including headers
5c94421 
Signed-off-by: Kim, Euna <[email protected]>
@eunakim0103
improved the header includes
a8659a2 
Signed-off-by: Kim, Euna <[email protected]>
@eunakim0103
Coverity - Copy without assign issues
0849b53
@eunakim0103
Coverity - logically dead code removal
307af96 
Signed-off-by: Kim, Euna <[email protected]>
@eunakim0103
Coverity - Missing assignment operator issues fixed
ff218d8 
Signed-off-by: Kim, Euna <[email protected]>
@eunakim0103 eunakim0103 requested a review from a team as a code owner July 18, 2023 06:05
@eunakim0103 eunakim0103 requested a review from bso-intel July 18, 2023 06:05
@eunakim0103 eunakim0103 temporarily deployed to aws July 18, 2023 06:21 — with GitHub Actions Inactive
@eunakim0103 eunakim0103 temporarily deployed to aws July 18, 2023 07:08 — with GitHub Actions Inactive
dm-vodopyanov
dm-vodopyanov requested changes Jul 18, 2023
View reviewed changes
Copy link
Contributor

@dm-vodopyanov dm-vodopyanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR has changes unrelated to the subject

@eunakim0103
Copy link
Contributor Author

Need to re-open this pull request after removing the unrelated changes.

@eunakim0103
Copy link
Contributor Author

Created a new PR: #10452
This branch/PR will be removed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dm-vodopyanov dm-vodopyanov dm-vodopyanov requested changes

@bso-intel bso-intel Awaiting requested review from bso-intel bso-intel is a code owner automatically assigned from intel/llvm-reviewers-runtime

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eunakim0103 @dm-vodopyanov