[SYCL][Bindless][3/4] Add experimental implementation of SYCL bindless images extension #10454
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s images extension This commit stands as the third commit of four to make code review easier, mostly covering the changes made to the user-facing SYCL API for the bindless images extension. The bindless images extension provides a new interface for allocating, creating, and accessing images in SYCL. Image memory allocation is seperated from image handle creation, and image handles can be passed to kernels without requesting access through accessors. This approach provides much more flexibility to the user, as well as enabling programs to implement features that were impossible to implement using standard SYCL images, such as a texture atlas. In addition to providing a new interface for images, this extension also provides initial experimental support for importing external memory into SYCL. Co-authored-by: Isaac Ault <[email protected]> Co-authored-by: Hugh Bird <[email protected]> Co-authored-by: Duncan Brawley <[email protected]> Co-authored-by: Przemek Malon <[email protected]> Co-authored-by: Chedy Najjar <[email protected]> Co-authored-by: Sean Stirling <[email protected]> Co-authored-by: Peter Zuzek <[email protected]> Implement revision 4 of the bindless images extension proposal: intel#9842
* Added missing `__SYCL_EXPORT` * Use fixed width `pi_uint64` instead of `unsigned long` * Added missing headers and forward declarations
przemektmalon
force-pushed
the
codeplay/bindless_images_sycl
branch
from
bbe79a5 to
965eafa
Compare
|
Please note that this PR depends on PR 2/4 to compile, hence CI won't pass until it that is merged. |
EwanC
approved these changes
Jul 19, 2023
There was a problem hiding this comment.
graph_impl.hpp changes LGTM. I tried this PR locally against our unmerged tests and it didn't regress anything.
|
Ping @intel/llvm-reviewers-runtime. |
steffenlarsen
approved these changes
Jul 21, 2023
|
Where are we at on this? Outstanding test failures? |
That, we need @intel/dpcpp-tools-reviewers approval, and there seem to be merge conflicts that need to be resolved. |
AlexeySachkov
approved these changes
Jul 25, 2023
maarquitos14
approved these changes
Jul 25, 2023
|
The fourth PR has been posted and can be reviewed alongside this PR. |
|
Build failure in post-commit: @przemektmalon could you please fix ASAP? |
Seanst98
added a commit
to codeplaysoftware/intel-llvm-mirror
that referenced
this pull request
Jul 26, 2023
Fix compiler error/warnings related to unused variables/parameters Post-commit fix for PR: intel#10454
Created #10574 to address this |
aelovikov-intel
pushed a commit
that referenced
this pull request
Jul 26, 2023
Fix compiler error/warnings related to unused variables/parameters Post-commit fix for PR: #10454 Co-authored-by: Przemek Malon <[email protected]>
steffenlarsen
pushed a commit
that referenced
this pull request
Aug 2, 2023
…CL bindless images extension (#10500) # Experimental Implementation of SYCL Bindless Images Extension This commit stands as the fourth, and final, commit of four to make code review easier, covering the additional tests for bindless images to the e2e test suite. Implementing [revision 4 of the bindless images extension proposal](#9842). This will not compile or run until [PR3](#10454) has been merged. However, it can be reviewed simultaneously with PR3. ## Overview The bindless images extension provides a new interface for allocating, creating, and accessing images in SYCL. Image memory allocation is seperated from image handle creation, and image handles can be passed to kernels without requesting access through accessors. This approach provides much more flexibility to the user, as well as enabling programs to implement features that were impossible to implement using standard SYCL images, such as a texture atlas. In addition to providing a new interface for images, this extension also provides initial experimental support for importing external memory into SYCL. ## Previous PRs * [1/4] [libclc](#9808) * [2/4] [PI/UR](#10112) * [3/4] [SYCL API](#10454) * [4/4] Tests <--- This one ## Authors Co-authored-by: Isaac Ault [email protected] Co-authored-by: Hugh Bird [email protected] Co-authored-by: Duncan Brawley [email protected] Co-authored-by: Przemek Malon [email protected] Co-authored-by: Chedy Najjar [email protected] Co-authored-by: Sean Stirling [email protected] Co-authored-by: Peter Zuzek [email protected] Co-authored-by: SYCL Unbound Team <[email protected]>
mdtoguchi
pushed a commit
to mdtoguchi/llvm
that referenced
this pull request
Oct 18, 2023
…s images extension (intel#10454) This commit stands as the third commit of four to make code review easier, mostly covering the changes made to the user-facing SYCL API for the [bindless images extension proposal](intel#9842). ### Overview The bindless images extension provides a new interface for allocating, creating, and accessing images in SYCL. Image memory allocation is seperated from image handle creation, and image handles can be passed to kernels without requesting access through accessors. This approach provides much more flexibility to the user, as well as enabling programs to implement features that were impossible to implement using standard SYCL images, such as a texture atlas. In addition to providing a new interface for images, this extension also provides initial experimental support for importing external memory into SYCL. ### Following Split PRs - [4/4] Add tests ### Authors Co-authored-by: Isaac Ault <[email protected]> Co-authored-by: Hugh Bird <[email protected]> Co-authored-by: Duncan Brawley <[email protected]> Co-authored-by: Przemek Malon <[email protected]> Co-authored-by: Chedy Najjar <[email protected]> Co-authored-by: Sean Stirling <[email protected]> Co-authored-by: Peter Zuzek <[email protected]>
mdtoguchi
pushed a commit
to mdtoguchi/llvm
that referenced
this pull request
Oct 18, 2023
Fix compiler error/warnings related to unused variables/parameters Post-commit fix for PR: intel#10454 Co-authored-by: Przemek Malon <[email protected]>
mdtoguchi
pushed a commit
to mdtoguchi/llvm
that referenced
this pull request
Oct 18, 2023
…CL bindless images extension (intel#10500) # Experimental Implementation of SYCL Bindless Images Extension This commit stands as the fourth, and final, commit of four to make code review easier, covering the additional tests for bindless images to the e2e test suite. Implementing [revision 4 of the bindless images extension proposal](intel#9842). This will not compile or run until [PR3](intel#10454) has been merged. However, it can be reviewed simultaneously with PR3. ## Overview The bindless images extension provides a new interface for allocating, creating, and accessing images in SYCL. Image memory allocation is seperated from image handle creation, and image handles can be passed to kernels without requesting access through accessors. This approach provides much more flexibility to the user, as well as enabling programs to implement features that were impossible to implement using standard SYCL images, such as a texture atlas. In addition to providing a new interface for images, this extension also provides initial experimental support for importing external memory into SYCL. ## Previous PRs * [1/4] [libclc](intel#9808) * [2/4] [PI/UR](intel#10112) * [3/4] [SYCL API](intel#10454) * [4/4] Tests <--- This one ## Authors Co-authored-by: Isaac Ault [email protected] Co-authored-by: Hugh Bird [email protected] Co-authored-by: Duncan Brawley [email protected] Co-authored-by: Przemek Malon [email protected] Co-authored-by: Chedy Najjar [email protected] Co-authored-by: Sean Stirling [email protected] Co-authored-by: Peter Zuzek [email protected] Co-authored-by: SYCL Unbound Team <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit stands as the third commit of four to make code review easier, mostly covering the changes made to the user-facing SYCL API for the bindless images extension proposal.
Overview
The bindless images extension provides a new interface for allocating, creating, and accessing images in SYCL. Image memory allocation is seperated from image handle creation, and image handles can be passed to kernels without requesting access through accessors. This approach provides much more flexibility to the user, as well as enabling programs to implement features that were impossible to implement using standard SYCL images, such as a texture atlas. In addition to providing a new interface for images, this extension also provides initial experimental support for importing external memory into SYCL.
Following Split PRs
Authors
Co-authored-by: Isaac Ault [email protected]
Co-authored-by: Hugh Bird [email protected]
Co-authored-by: Duncan Brawley [email protected]
Co-authored-by: Przemek Malon [email protected]
Co-authored-by: Chedy Najjar [email protected]
Co-authored-by: Sean Stirling [email protected]
Co-authored-by: Peter Zuzek [email protected]