[SYCL] Move Device Config File test from Unit tests to lit tests. #10456
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maronas, Marcos <[email protected]>
Signed-off-by: Maronas, Marcos <[email protected]>
Signed-off-by: Maronas, Marcos <[email protected]>
AlexeySachkov
approved these changes
Jul 19, 2023
…v_config_file_test
|
Precommit failure is known and unrelated. |
mdtoguchi
pushed a commit
to mdtoguchi/llvm
that referenced
this pull request
Oct 18, 2023
…tel#10456) This test requires an autogenerated file (DeviceConfigFile.inc) to be present at the time of its compilation, and it was possible in some scenarios that the autogenerated file wasn't generated before the compilation of the test, resulting in an error. Moving the test to `sycl/test` should prevent that from happening. --------- Signed-off-by: Maronas, Marcos <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test requires an autogenerated file (DeviceConfigFile.inc) to be present at the time of its compilation, and it was possible in some scenarios that the autogenerated file wasn't generated before the compilation of the test, resulting in an error. Moving the test to
sycl/testshould prevent that from happening.