Skip to content

[SYCL][E2E] Use %{run*} placeholder in tests #10470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 19, 2023

Conversation

aelovikov-intel
Copy link
Contributor

Needed to properly handle run_launcher.

Needed to properly handle run_launcher.
@aelovikov-intel aelovikov-intel requested a review from a team as a code owner July 19, 2023 16:28
@aelovikov-intel aelovikov-intel temporarily deployed to aws July 19, 2023 16:40 — with GitHub Actions Inactive
@aelovikov-intel aelovikov-intel temporarily deployed to aws July 19, 2023 17:24 — with GitHub Actions Inactive
// RUN: env ONEAPI_DEVICE_SELECTOR="*:acc" %t.out | FileCheck %s --check-prefixes=CHECK-ACC-ONLY
// RUN: env ONEAPI_DEVICE_SELECTOR="*:gpu" %t.out | FileCheck %s --check-prefixes=CHECK-GPU-ONLY
// RUN: env ONEAPI_DEVICE_SELECTOR="*:cpu" %t.out | FileCheck %s --check-prefixes=CHECK-CPU-ONLY
// RUN: env ONEAPI_DEVICE_SELECTOR="*:acc" %{run-unfiltered-devices} %t.out | FileCheck %s --check-prefixes=CHECK-ACC-ONLY
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does %{run-unfiltered-devices} just a nop to be stylistically accurate and to prevent adding %{run} here? Or there is something more?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is, see

run_unfiltered_substitution = ''
if extra_env:
run_unfiltered_substitution = 'env {} '.format(' '.join(extra_env))
run_unfiltered_substitution += test.config.run_launcher
substitutions.append(('%{run-unfiltered-devices}', run_unfiltered_substitution))

@aelovikov-intel
Copy link
Contributor Author

aelovikov-intel commented Jul 19, 2023

Failed Tests (1):
  Basic/host-task-dependency.cpp

isn't modified here and thus unrelated. For the record, failed like this (HIP AMDGPU):

/__w/llvm/llvm/llvm/sycl/test-e2e/Basic/host-task-dependency.cpp:192:10: error: CHECK: expected string not found in input
// CHECK:---> piKernelCreate(
         ^
<stdin>:568:29: note: scanning from here
---> piEnqueueMemBufferRead(
                            ^
<stdin>:578:91: note: possible intended match here
Memory access fault by GPU node-1 (Agent handle: 0x231b8d0) on address 0x7fdeb5e00000. Reason: Page not present or supervisor privilege.                                                                                      ^

@aelovikov-intel aelovikov-intel merged commit 195a437 into intel:sycl Jul 19, 2023
@aelovikov-intel aelovikov-intel deleted the placeholder-run branch July 19, 2023 21:45
mdtoguchi pushed a commit to mdtoguchi/llvm that referenced this pull request Oct 18, 2023
Needed to properly handle run_launcher.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants