Skip to content

[XPTI] Additional TBB dependency removal #10486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Aug 2, 2023

Conversation

tovinkere
Copy link
Contributor

@tovinkere tovinkere commented Jul 20, 2023

Semantic and correctness testing of the XPTI framework relies on std::for_each parallel execution policy. However, this adds an install dependency of the TBB development package. To remove this inconvenience, the semantic tests that used std::for_each have been modified to use the same thread pool functionality adopted by the performance tests.

  + std::for_each on Linux requires you to install tbb-dev
    and update CMake to link in TBB, whereas it is seamless
    on Windows. To avoid this dependency, the std::for_each
    have been replaced to use a parallel implementation
    using the thread pool library used for performance tests

Signed-off-by: Vasanth Tovinkere <[email protected]>
@tovinkere tovinkere requested a review from a team as a code owner July 20, 2023 01:40
@tovinkere tovinkere requested a review from sergey-semenov July 20, 2023 01:40
@tovinkere tovinkere temporarily deployed to aws July 20, 2023 01:54 — with GitHub Actions Inactive
@tovinkere tovinkere temporarily deployed to aws July 20, 2023 02:39 — with GitHub Actions Inactive
@tovinkere tovinkere temporarily deployed to aws July 20, 2023 23:48 — with GitHub Actions Inactive
@tovinkere tovinkere temporarily deployed to aws July 21, 2023 00:38 — with GitHub Actions Inactive
@tovinkere
Copy link
Contributor Author

@intel/llvm-gatekeepers The failures appear to be unrelated to the PR as it is failing because the test cannot create a Level Zero tracer. Has this been recently reported in other PRs?

 + New hash algorithm causes three test failures, so reverting
   to old algorithm

Signed-off-by: Vasanth Tovinkere <[email protected]>
@tovinkere tovinkere temporarily deployed to aws July 21, 2023 22:29 — with GitHub Actions Inactive
@tovinkere
Copy link
Contributor Author

@intel/llvm-gatekeepers The failures appear to be unrelated to the PR as it is failing because the test cannot create a Level Zero tracer. Has this been recently reported in other PRs?

@intel/llvm-gatekeepers The new hash algorithm causes the 3 tests to fail and have been reverted and will be part of a different PR when fully resolved.

@tovinkere tovinkere temporarily deployed to aws July 21, 2023 23:07 — with GitHub Actions Inactive
@tovinkere
Copy link
Contributor Author

tovinkere commented Jul 22, 2023

@intel/llvm-gatekeepers The failures appear to be unrelated to the PR as it is failing because the test cannot create a Level Zero tracer. Has this been recently reported in other PRs?

@intel/llvm-gatekeepers The new hash algorithm causes the 3 tests to fail and have been reverted and will be part of a different PR when fully resolved.

@KseniyaTikhomirova Can you please review?

@tovinkere tovinkere changed the title [XPTI] New hash function and additional TBB dependency removal [XPTI] Additional TBB dependency removal Jul 25, 2023
@tovinkere tovinkere temporarily deployed to aws July 27, 2023 21:08 — with GitHub Actions Inactive
@tovinkere tovinkere temporarily deployed to aws July 27, 2023 21:47 — with GitHub Actions Inactive
@tovinkere tovinkere temporarily deployed to aws August 1, 2023 17:25 — with GitHub Actions Inactive
@tovinkere tovinkere temporarily deployed to aws August 1, 2023 18:48 — with GitHub Actions Inactive
Copy link
Contributor

@KseniyaTikhomirova KseniyaTikhomirova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sergey-semenov sergey-semenov merged commit ed79eed into intel:sycl Aug 2, 2023
@tovinkere
Copy link
Contributor Author

LGTM

@intel/llvm-gatekeepers Can you please merge? Thanks!

mdtoguchi pushed a commit to mdtoguchi/llvm that referenced this pull request Oct 18, 2023
Semantic and correctness testing of the XPTI framework relies on
std::for_each parallel execution policy. However, this adds an install
dependency of the TBB development package. To remove this inconvenience,
the semantic tests that used std::for_each have been modified to use the
same thread pool functionality adopted by the performance tests.

---------

Signed-off-by: Vasanth Tovinkere <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants