-
Notifications
You must be signed in to change notification settings - Fork 787
[XPTI] Additional TBB dependency removal #10486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Vasanth Tovinkere <[email protected]>
Signed-off-by: Vasanth Tovinkere <[email protected]>
+ std::for_each on Linux requires you to install tbb-dev and update CMake to link in TBB, whereas it is seamless on Windows. To avoid this dependency, the std::for_each have been replaced to use a parallel implementation using the thread pool library used for performance tests Signed-off-by: Vasanth Tovinkere <[email protected]>
@intel/llvm-gatekeepers The failures appear to be unrelated to the PR as it is failing because the test cannot create a Level Zero tracer. Has this been recently reported in other PRs? |
+ New hash algorithm causes three test failures, so reverting to old algorithm Signed-off-by: Vasanth Tovinkere <[email protected]>
@intel/llvm-gatekeepers The new hash algorithm causes the 3 tests to fail and have been reverted and will be part of a different PR when fully resolved. |
@KseniyaTikhomirova Can you please review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@intel/llvm-gatekeepers Can you please merge? Thanks! |
Semantic and correctness testing of the XPTI framework relies on std::for_each parallel execution policy. However, this adds an install dependency of the TBB development package. To remove this inconvenience, the semantic tests that used std::for_each have been modified to use the same thread pool functionality adopted by the performance tests. --------- Signed-off-by: Vasanth Tovinkere <[email protected]>
Semantic and correctness testing of the XPTI framework relies on std::for_each parallel execution policy. However, this adds an install dependency of the TBB development package. To remove this inconvenience, the semantic tests that used std::for_each have been modified to use the same thread pool functionality adopted by the performance tests.